Calculate Scroll based on Childs relative position to ScrolledPanel#1950
Merged
swt2c merged 2 commits intowxWidgets:masterfrom Feb 27, 2025
Merged
Calculate Scroll based on Childs relative position to ScrolledPanel#1950swt2c merged 2 commits intowxWidgets:masterfrom
swt2c merged 2 commits intowxWidgets:masterfrom
Conversation
7 tasks
seanbudd
commented
Apr 20, 2021
seanbudd
commented
Apr 20, 2021
Contributor
Author
|
didn't mean to close this |
This was referenced Jun 15, 2021
|
CC @RobinD42. |
|
cc @@swt2c |
Collaborator
It seems OK to me, but is there a way to observe the problem in the existing code (e.g., in a demo or something)? |
Contributor
Author
I'm not sure on the standard way to create a minimal sample for this repo. |
Contributor
Author
|
Bumping this |
Contributor
Author
|
Thanks @swt2c ! Apologies I never got around to a sample |
5 tasks
seanbudd
added a commit
to nvaccess/nvda
that referenced
this pull request
Oct 14, 2025
Closes #17751 Summary of the issue: Solving #12224 required introducing a hack to fix wx.lib.scrolledpanel.ScrolledPanel. This has now been fixed in wxPython 4.2.3: wxWidgets/Phoenix#1950. As such, we can revert the hack now Description of user facing changes: None Description of developer facing changes: wxPython has been updated, this can cause API breaking changes sometimes Support class has been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScrolledPanels do not automatically scroll via tabbing if the focused control is not a direct child of theScrolledPanelInstead of using
child.GetRect(), which calculates the position relative to the parent, calculate the position of thechildrelative to theScrolledPanelitself.