Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates wxPython from version 4.2.2 to 4.2.3 and removes a workaround for a scrolling issue that has been fixed upstream in the new wxPython version.
- Updates wxPython dependency to version 4.2.3
- Removes the
TabbableScrolledPanelworkaround class that was created to fix issue #12224 - Reverts to using the standard
wx.lib.scrolledpanel.ScrolledPaneldirectly
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Updates wxPython version dependency from 4.2.2 to 4.2.3 |
| source/gui/nvdaControls.py | Removes the TabbableScrolledPanel workaround class and its export |
| source/gui/settingsDialogs.py | Reverts to using standard scrolledpanel.ScrolledPanel instead of the custom workaround |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #17751
Summary of the issue:
Solving #12224 required introducing a hack to fix
wx.lib.scrolledpanel.ScrolledPanel.This has now been fixed in wxPython 4.2.3: wxWidgets/Phoenix#1950.
As such, we can revert the hack now
Description of user facing changes:
None
Description of developer facing changes:
wxPython has been updated, this can cause API breaking changes sometimes
Support class has been removed.
Description of development approach:
Revert changes from #12300
Update wxPython
Testing strategy:
Tested str from #12224 did not regress
Known issues with pull request:
It may be worth considering retaining an alias
Code Review Checklist: