"select" and "option" added to allowed HTML for settings.#2349
Merged
jasonbahl merged 2 commits intowp-graphql:developfrom Apr 22, 2022
eavonius:develop
Merged
"select" and "option" added to allowed HTML for settings.#2349jasonbahl merged 2 commits intowp-graphql:developfrom eavonius:develop
jasonbahl merged 2 commits intowp-graphql:developfrom
eavonius:develop
Conversation
The get_allowed_wp_kses_html function was missing "select" and "option" which stripped the HTML when trying to add settings fields. I noticed this when making an update I'm working on for the wpgraphql-cors repo which has its own tab of settings. Without this change, its not possible to create settings of the "select" type.
Collaborator
|
Thanks @eavonius! |
jasonbahl
previously approved these changes
Apr 22, 2022
|
Code Climate has analyzed commit c0b3ad2 and detected 0 issues on this pull request. View more on Code Climate. |
jasonbahl
added a commit
that referenced
this pull request
Apr 22, 2022
Amendment to #2349 to add "selected" attribute to allowed HTML.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
The get_allowed_wp_kses_html function was missing "select" and "option" which stripped the HTML when trying to add settings fields.
I noticed this when making an update I'm working on for the wpgraphql-cors repo which has its own tab of settings. Without this change, its not possible to create settings of the "select" type.
Does this close any currently open issues?
…
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
…
Where has this been tested?
Operating System: Apache on php 7.4 in Docker
WordPress Version: 5.9