Amendment to #2349 to add "selected" attribute to allowed HTML.#2351
Merged
jasonbahl merged 3 commits intowp-graphql:developfrom Apr 22, 2022
eavonius:develop
Merged
Amendment to #2349 to add "selected" attribute to allowed HTML.#2351jasonbahl merged 3 commits intowp-graphql:developfrom eavonius:develop
jasonbahl merged 3 commits intowp-graphql:developfrom
eavonius:develop
Conversation
|
Code Climate has analyzed commit e8aeb7b and detected 0 issues on this pull request. View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
The get_allowed_wp_kses_html function was missing the "selected" attribute which stripped the HTML when trying to save a select field in custom wpgraphql settings. This should have been included with #2349 but I didn't realize it wasn't saving until now. Oops =/.
Does this close any currently open issues?
…
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
…
Where has this been tested?
Operating System: Apache2 PHP 7.4 on Docker
WordPress Version: 5.9