Avoid deleting theme if the specified version cannot be found#349
Merged
schlessera merged 3 commits intomainfrom Feb 7, 2023
Merged
Avoid deleting theme if the specified version cannot be found#349schlessera merged 3 commits intomainfrom
schlessera merged 3 commits intomainfrom
Conversation
Member
It was already added prior to that, with wp-cli/wp-cli@d4fa0c6 |
schlessera
approved these changes
Feb 7, 2023
2 tasks
msaladna
added a commit
to apisnetworks/apiscp-webapp-wordpress
that referenced
this pull request
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144
The "delete before install" behavior was originally added in wp-cli/wp-cli#1510
Interestingly, it doesn't appear necessary and may have been copy paste from the
wp plugin updatecode.Seems like it should be fine to remove if all of the existing tests pass. I moved a few other relevant tests into my new feature file.