Better 'version' support for wp [plugin|theme] update.#1510
Merged
danielbachhuber merged 7 commits intowp-cli:masterfrom Nov 24, 2014
Merged
Better 'version' support for wp [plugin|theme] update.#1510danielbachhuber merged 7 commits intowp-cli:masterfrom
wp [plugin|theme] update.#1510danielbachhuber merged 7 commits intowp-cli:masterfrom
Conversation
Member
|
Can you merge master to fix tests, and add some tests to cover this behavior? |
Contributor
Author
|
I take it that these would be behat tests, right? Can you point me to On 11/24/2014 12:24 PM, Daniel Bachhuber wrote:
|
Member
|
You can append to this file: https://github.com/wp-cli/wp-cli/blob/master/features/plugin.feature Here's an introduction to tests: https://github.com/wp-cli/wp-cli/blob/master/CONTRIBUTING.md#running-and-writing-tests |
`version_compare()` can return `-1` or `0`, both of which are falsy. This caused inconsistent results when the WordPress API started returning versions out of order
Contributor
Author
danielbachhuber
added a commit
that referenced
this pull request
Nov 24, 2014
Better 'version' support for `wp [plugin|theme] update`.
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1488.
Pretty straightforward, though in each case I forced the 'force' flag in order to override any cached version values. Not the most elegant solution in the world, but effective for the case when you want to specify the version number.