This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Conversation
fix crash iOS9
Added support for automaticallyWaitsToMinimizeStalling property on iOS
Fixed Exoplayer doesn't work with mute=true TheWidlarzGroup#1696
- Bump Exoplayer to 2.10.4 - Remove deprecated usages of Exoplayer methdos - Add `ReactExoplayerConfig` as extension points to configure the Exoplayer instance
fix typo in README
…Group#1768) The progress message handler will duplicate recursions of the `onProgressMessage` handler on change of player state from any state to STATE_READY with `playWhenReady` is true (when video is not paused). This clears the messages on STATE_IDLE and STATE_BUFFERING to break the recursion.
…ues have not been released
…ntroller-keypath-leak Fix playerviewcontroller keypath leak of observers
Fix broken link for ignoresilentswitch
…2311) Fix AudioFocus bug that could cause the player to stop responding to play/pause in some instances. Fixes issue TheWidlarzGroup#1945 This was caused by the player requesting audio focus on each play (un-pause) and that resulted in a small window of Audio focus loss and then gain. The focus loss results in the player being paused while the player was supposed to play at the time. The solution is to keep track of Audio focus and not request new focus if we already have it.
Upgrade ExoPlayer from 2.11.4 to 2.13.2 and fix any issues related to the upgrade and deprecated method use.
…y-rate-modifier Fix: iOS rate is reset to 1.0 after play/pause TheWidlarzGroup#1930
Update exoplayer to allow pre-init and content clear
Fix for tvOS native audio menu language selector
Resolved ignored silent switch in iOS when player is set to paused
2 tasks
6e97fa3 to
2e22a9c
Compare
This version is available from the Google repository, so it avoids us needing to host it ourselves since jcenter is shutting down soon and already pretty unreliable
|
I created a separate PR proposing we bump exoplayer to a slightly higher version. |
8 tasks
…xoplayer-2.13.3 Bump exoplayer to 2.13.3
These dependencies were previously removed on our fork because they are Apache-2.0, and they accidentally got reintroduced when merging the updates from the main repo.
mchowning
approved these changes
Feb 5, 2022
There was a problem hiding this comment.
This is working well in my testing. We just need to remember to create the 5.2.0-wp-1 tag once this is merged and update the reference in WordPress/gutenberg#38426.
I'm not merging this since I did the latest changes, and I wanted to give you a chance to review them @hypest .
Author
|
Thanks for the extra context @mchowning ! Tried it locally with the gutenberg-mobile demo app and a video-background on a Cover block and works fine. Looks good to me 👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR to try out updating from upstream, to bring in updated version of ExoPlayer.