Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Update from upstream v5.2.0#15

Merged
mchowning merged 102 commits intowp-forkfrom
wp-fork-upstream-5.2.0
Feb 9, 2022
Merged

Update from upstream v5.2.0#15
mchowning merged 102 commits intowp-forkfrom
wp-fork-upstream-5.2.0

Conversation

@hypest
Copy link
Copy Markdown

@hypest hypest commented Dec 9, 2021

Draft PR to try out updating from upstream, to bring in updated version of ExoPlayer.

andrewchae and others added 30 commits August 1, 2019 15:08
fix crash iOS9
Added support for automaticallyWaitsToMinimizeStalling property on iOS
- Bump Exoplayer to 2.10.4
- Remove deprecated usages of Exoplayer methdos
- Add `ReactExoplayerConfig` as extension points to configure the Exoplayer instance
…Group#1768)

The progress message handler will duplicate recursions of the `onProgressMessage` handler on change of player state from any state to STATE_READY with `playWhenReady` is true (when video is not paused). This clears the messages on STATE_IDLE and STATE_BUFFERING to break the recursion.
…ntroller-keypath-leak

Fix playerviewcontroller keypath leak of observers
milansusnjar and others added 12 commits April 8, 2021 13:52
Fix broken link for ignoresilentswitch
…2311)

Fix AudioFocus bug that could cause the player to stop responding to play/pause in some instances.

Fixes issue TheWidlarzGroup#1945

This was caused by the player requesting audio focus on each play (un-pause) and that resulted in a small window of Audio focus loss and then gain. The focus loss results in the player being paused while the player was supposed to play at the time. The solution is to keep track of Audio focus and not request new focus if we already have it.
Upgrade ExoPlayer from 2.11.4 to 2.13.2 and fix any issues related to the upgrade and deprecated method use.
…y-rate-modifier

Fix: iOS rate is reset to 1.0 after play/pause TheWidlarzGroup#1930
Update exoplayer to allow pre-init and content clear
Fix for tvOS native audio menu language selector
Resolved ignored silent switch in iOS when player is set to paused
@hypest hypest force-pushed the wp-fork-upstream-5.2.0 branch from 6e97fa3 to 2e22a9c Compare December 9, 2021 15:07
This version is available from the Google repository, so it avoids us
needing to host it ourselves since jcenter is shutting down soon and
already pretty unreliable
@mchowning
Copy link
Copy Markdown

I created a separate PR proposing we bump exoplayer to a slightly higher version.

mchowning and others added 3 commits February 2, 2022 11:28
…xoplayer-2.13.3

Bump exoplayer to 2.13.3
These dependencies were previously removed on our fork because they are
Apache-2.0, and they accidentally got reintroduced when merging the
updates from the main repo.
@mchowning mchowning marked this pull request as ready for review February 5, 2022 00:49
Copy link
Copy Markdown

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well in my testing. We just need to remember to create the 5.2.0-wp-1 tag once this is merged and update the reference in WordPress/gutenberg#38426.

I'm not merging this since I did the latest changes, and I wanted to give you a chance to review them @hypest .

@mchowning
Copy link
Copy Markdown

Note that in faecf40 I removed the Apache dependencies that were accidentally included when resolving a merge conflict. They were previously removed in earlier PRs (shaka, keymirror).

@hypest
Copy link
Copy Markdown
Author

hypest commented Feb 8, 2022

Thanks for the extra context @mchowning ! Tried it locally with the gutenberg-mobile demo app and a video-background on a Cover block and works fine. Looks good to me 👍

@mchowning mchowning merged commit ca1052c into wp-fork Feb 9, 2022
@mchowning mchowning deleted the wp-fork-upstream-5.2.0 branch February 9, 2022 14:36
@mchowning mchowning mentioned this pull request Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.