Fixed Exoplayer doesn't work with mute=true #1696#1699
Merged
CHaNGeTe merged 1 commit intoTheWidlarzGroup:masterfrom Sep 21, 2019
Merged
Fixed Exoplayer doesn't work with mute=true #1696#1699CHaNGeTe merged 1 commit intoTheWidlarzGroup:masterfrom
CHaNGeTe merged 1 commit intoTheWidlarzGroup:masterfrom
Conversation
|
Any reason not to merge this? 👍 |
|
Would be great if this can be merged. Works nicely in our testing. |
|
Works for us too |
jensellfors
approved these changes
Aug 19, 2019
CHaNGeTe
approved these changes
Aug 21, 2019
jensellfors
approved these changes
Aug 21, 2019
Contributor
|
@andrewchae thanks for submitting this, can you please add a line to the changelog as well. Then we can merge this |
beauner69
pushed a commit
to beauner69/react-native-video
that referenced
this pull request
Oct 10, 2019
Fixed Exoplayer doesn't work with mute=true TheWidlarzGroup#1696 (rebased from commit b954a4f)
Contributor
|
Is this fix in a release yet? If not do we know when it might be? |
|
@scgough looks like it's in 5.1.0@alpha |
|
Is there a rough estimate for when this fix will be out of alpha and in a stable version? |
Closed
Closed
|
Reproduced with this fix in some cases, will check why and give more details |
|
facing same issue in version 5.1.1 |
|
same here!!! |
|
Did Exoplayer update #2317 fix this issue? |
|
this issue still exists with the current version 5.2.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:
Update the documentation
If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.
Update the changelog
After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.
Provide an example of how to test the change
If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.
Focus the PR on only one area
Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.
Describe the changes
Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.