This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Bump exoplayer to 2.13.3#16
Merged
mchowning merged 1 commit intowp-fork-upstream-5.2.0from Feb 2, 2022
Merged
Conversation
This version is available from the Google repository, so it avoids us needing to host it ourselves since jcenter is shutting down soon and already pretty unreliable
2 tasks
hypest
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
LGTM!
I gave this a try on WPAndroid (version alpha-339, against the gb-mobile PR) and the video plays fine as the background of a cover block 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version is available from the Google repository, so it avoids us needing to host it ourselves since jcenter is shutting down soon and is already pretty unreliable.
These same changes are unreleased in the main react-native-video repository: https://github.com/react-native-video/react-native-video/pull/2552/files
I'm targeting your PR with this PR so you can easily see these changes in isolation. That means we'll need to merge both of these before we can update and merge the Gutenberg PR