Update react-native-video from upstream#4361
Merged
Conversation
871848b to
2f3756a
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
2f3756a to
0e9a37e
Compare
3 tasks
45828f3 to
83299cd
Compare
Contributor
|
👋 @hypest ! Heads up that I force-pushed to update this to point at WordPress/gutenberg#38426. |
mchowning
approved these changes
Feb 5, 2022
Contributor
mchowning
left a comment
There was a problem hiding this comment.
This is working well in my testing.
Contributor
Author
|
Just leaving a comment that it works for me too (tested it via a video playing as the background on a Cover block) 👍. Also, I understand that the failing CI jobs (with error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR to test out the upgrade-from-upstream for react-native-video, to bring in updated ExoPlayer.
Related PRs
To test:
PR submission checklist: