Issue/874 fix nested lists handling#973
Closed
SergioEstevao wants to merge 16 commits intodevelopfrom
Closed
Conversation
# Conflicts: # gutenberg # react-native-aztec/ios/Cartfile # react-native-aztec/ios/Cartfile.resolved
# Conflicts: # gutenberg
# Conflicts: # gutenberg
5 tasks
Contributor
|
@SergioEstevao - Thanks for handling this! I did a smoke test on the issue, and it seems to be resolved 🎉
Check the gif for a better visual explanation:
|
Contributor
|
The web side has a similar (but not completely the same) behavior, so it's probably an issue in the web side that is affecting us.
|
Contributor
Author
|
I saw similar things, with the system showing two bullets in the same line,
I will check the HTML produced and if what the app is showing makes sense,
I will merge this.
…On Mon, 13 May 2019 at 11:54, etoledom ***@***.***> wrote:
The web side has a similar (but not completely the same) behavior, so it's
probably an issue in the web side that is affecting us.
[image: web_list_issue]
<https://user-images.githubusercontent.com/9772967/57616380-38c0cf80-757e-11e9-8469-3239602ffc8a.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#973 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE7CULICBHCKLMLHGDYGS3PVFCGBANCNFSM4HMESNHQ>
.
|
Contributor
Author
|
@etoledom I just printed the HTML being produced by the JS side and the HTML we are producing in Aztec looks right. Not sure what to do. |
Contributor
Author
|
Closing in favour of: #991 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #874
Related GB PR: WordPress/gutenberg#15566
Relate Aztec PR: wordpress-mobile/AztecEditor-iOS#1181
This PR updates the list code to support the following:
How to test: