Conversation
This converter beside doing the regular attribute setting for li element it also check if there is children nodes to decide if a implicit representation is needed.
etoledom
left a comment
There was a problem hiding this comment.
Hey @SergioEstevao !
I tested with the same snippet you shared and I keep getting the same result as shown in the issue:
I tried cleaning the project's build folder and nuking DerivedData. And I do see the test passing locally, so I'm not sure what's happening.
Let me know if it works on your side and I'll check again, maybe I'm doing something wrong? 🤔
|
@etoledom Thanks for the check! I fixed the issue can you check it again? |
etoledom
left a comment
There was a problem hiding this comment.
Now it's working great 🎉
|
Hey @SergioEstevao - I did a second pass to this PR after all the new commits, and I did find one issue: After pressing enter to scape the list and coming back again, when I try to press double enter to scape the list again, the bullet stays with the cursor:
I noticed that this also happens on develop branch, so it shouldn't be a blocker to merge this PR ✅ |
Fixes #1180
This PR addresses the issues reported on the ticket above by creating a dedicated LIConverter in order to check when to add a intrinsic representation for the
The main logic here is that if the Li element has children elements that are nested lists and no text defined we need to add "\n" to the content in order for the marker to be shown.
To test:
You should get something like this rendered:
Besides this test the remaining logic of lists should be retested: