Skip to content

Release 1.37.0#2614

Merged
ceyhun merged 82 commits intotrunkfrom
release/1.37.0
Sep 18, 2020
Merged

Release 1.37.0#2614
ceyhun merged 82 commits intotrunkfrom
release/1.37.0

Conversation

@ceyhun
Copy link
Copy Markdown
Contributor

@ceyhun ceyhun commented Sep 14, 2020 •
edited
Loading

Release for Gutenberg Mobile 1.37.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Aztec dependencies are pointing to a stable release.
    • iOS: Aztec dependencies match in RNTAztecView.podspec and gutenberg/packages/react-native-aztec/RNTAztecView.podspec.
  • Gutenberg 'Podfile.lock' inside 'gutenberg/package/react-native-editor/ios/' is updated to the release number.
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

marecar3 and others added 30 commits August 8, 2020 00:27
@marecar3
Update gb reference
891db28
@marecar3
Update gb reference
ab24e4e
@marecar3
Merge branch 'develop' into feature/unsupported-block-editor-jetpack-…
aaab4a3 
…sso-enabled

# Conflicts:
#	gutenberg
@marecar3
Update gb reference
ec1e96a
@etoledom
Update gutenberg ref
66789f0
@etoledom
Update gutenberg ref
3e6dd62
@etoledom
Update gutenberg ref
4068a84
@etoledom
Update gutenberg ref
8f26b11
@etoledom
Merge remote-tracking branch 'origin/develop' into feature/unsupporte…
cfa0f08 
…d-block-editor-jetpack-sso-enabled
@etoledom
Update gutenberg ref
2a58be1
@marecar3
Update gb submodule
dc65b34
@marecar3
Update gb submodule
5412f2c
@marecar3
Update gb reference
c1f4f38
@marecar3
Merge branch 'develop' into feature/unsupported-block-editor-jetpack-…
f0971bd 
…sso-enabled
@etoledom
Adding resources/unsupported-block-editor/remove-nux.js to hide wpc…
4bb559d 
…om nux UI
@etoledom
Update gutenberg ref
3e3a13c
@etoledom
Update gutenberg ref
77ef0f3
@etoledom
Prettier fixes
36db27e
@marecar3
Update gb reference
2fb0b46
@marecar3
Update gb-reference
de314f6
@marecar3
Update gb reference
e080610
@marecar3
Update gb reference
0772a6c
@marecar3
Update gb-mobile reference
144d774
@marecar3
Update gb reference
2f2e956
@marecar3
Merge branch 'develop' into feature/unsupported-block-editor-jetpack-…
c6eebd2 
…sso-enabled

# Conflicts:
#	gutenberg
@marecar3
Update gb reference
877d93a
@marecar3
Update gb reference
f350e4f
@marecar3
Merge branch 'develop' into move-some-ube-injection-code-to-gutenberg…
9813785 
…-mobile-repo
@etoledom
Adding new script to override automattic/nux localstorage on unsuppor…
b5cc771 
…ted block editor
@etoledom
Remove unnecessary log statement
77be79e
This was referenced Sep 14, 2020
Merged
Merged
Merged
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 14, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun requested a review from cameronvoell September 14, 2020 18:16
@ceyhun ceyhun marked this pull request as ready for review September 14, 2020 18:16
@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Sep 15, 2020 •
edited
Loading

Tested with the WPiOS ipa:

DarkMode-1

  • Gallery block - Dark mode - steps
  • Shortcode block - Dark mode - steps
  • Media Text block - Dark mode - steps

Tested with the WPAndroid apk:

Group-1

  • Group - AppenderButton is rendered - steps
  • Group - Deep nesting is possible (iOS only) - steps
  • Group - Check if Group placeholder is visible for the unselected state - steps
  • Group - Check if Group placeholder is render in nested structure - steps
  • Group - Nested block have proper border styling - steps
  • Group - Nested block have proper margins values - steps
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - steps

Spacer-1

  • Spacer block - Spacer is rendered without crash - steps
  • Spacer block - Settings: Control spacer height using the slider - steps
  • Spacer block - Settings: Control spacer height using the text input - steps

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - steps

  • Buttons block - Buttons inline appender - steps

  • Buttons block - Add another Button inside Buttons using inserter - steps

  • Buttons block - Button's wrapper grows properly - steps
    Buttons-2

  • Buttons block - Removing Button along with Buttons block - steps

  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - steps

Buttons-3

  • Buttons block - Wrapping Buttons - steps
  • Buttons block - Buttons alignment options - steps

Button-6

  • Buttons block - Settings: Open in new tab - steps
  • Buttons block - Settings: Link rel - steps
  • Buttons block - Settings: Link URL - steps
  • Buttons block - Settings: Remove link - steps
  • Buttons block - Settings: Synchronize with button options - steps

Color Settings - 1

  • Colors Segmented Controls - steps
  • Scroll color palette to start - steps
  • Scroll color palette to the end - steps

@pinarol pinarol mentioned this pull request Sep 15, 2020
Closed
@ceyhun
Copy link
Copy Markdown
Contributor Author

ceyhun commented Sep 16, 2020 •
edited
Loading

Tested on WPiOS build 34942

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

@cameronvoell
Copy link
Copy Markdown
Contributor

cameronvoell commented Sep 17, 2020

Tested on WPAndroid build WordPress-pr-12949-build-72618.apk, all tests green! ✅

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

This was referenced Sep 17, 2020
Closed
Closed
@lukewalczak
Copy link
Copy Markdown
Contributor

lukewalczak commented Sep 17, 2020 •
edited
Loading

TESTING

device: iPhone XS 13.7

Cover-1

  • Cover - Add image background from WordPress Media library - steps

  • Cover - Change Minimum height in pixels - steps

  • Cover - Change Background Opacity - steps

  • Cover - Image focal point is rendered properly - steps

  • Cover - Custom color is rendered properly - steps

Editor Theme - 1

  • Default Colors - Check that default colors still load - steps
  • Default Gradients - Check that default gradients still load - steps
  • Custom Colors - Check that custom colors load in the editor - steps

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - steps
  • Active icon gets product color - steps
  • Only active icons are visible when not selected - steps

MultipleUpload-1

  • Simultaneous uploads - steps

MediaText-1

  • Media Text block - Insert image from device (failing) - steps
  • Media Text block - Close/Re-open post with an ongoing image upload - steps

MediaText-2

  • Media Text block - Insert video from device (cancel) - steps
  • Media Text block - Insert image from device (cancel) - steps

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - steps
  • Columns - Columns percentage mechanism - column's slider input - steps

❓ Cannot type , which is the equivalent for . on a keyboard in European regions.
EDIT: After discussion, it's rather a rare case and it will be tracked as a separate issue

  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- steps
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- steps
  • Columns - Multiple slider in columns parent - steps
  • Columns - Columns block is added with default number of Column - steps
  • Columns - Adding Column with AppenderButton - steps
  • Columns - Adding and removing Column with BottomSheet Stepper control - steps

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps
  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • Columns - Unselected Column placeholder is streched to content in nested structure- steps

Gallery-1

  • Gallery block - Close/Re-open post with an ongoing image upload - steps
  • Gallery block - Close post with an ongoing image upload - steps

Gallery-2

  • Gallery block - Insert image from device (failing) - steps
  • Gallery block - Insert image from device (cancel) - steps

Gallery-3

  • Gallery block - Add Gallery Caption - steps
  • Gallery block - Add Gallery Image Caption - steps
  • Gallery block - Try adding same images from WP Media library and moving the images around - steps

cameronvoell
cameronvoell approved these changes Sep 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the social icons fix looks good, combined with the positive results from all the other manual tests, and I believe we are good to go! :shipit:

@ceyhun ceyhun merged commit 1ab78ee into trunk Sep 18, 2020
@ceyhun ceyhun deleted the release/1.37.0 branch September 18, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cameronvoell cameronvoell cameronvoell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ceyhun @pinarol @cameronvoell @lukewalczak @marecar3 @etoledom @jkmassel @mchowning