Skip to content

Adding remove NUX script for Unsupported Block Editor.#2561

Merged
etoledom merged 32 commits intodevelopfrom
move-some-ube-injection-code-to-gutenberg-mobile-repo
Sep 14, 2020
Merged

Adding remove NUX script for Unsupported Block Editor.#2561
etoledom merged 32 commits intodevelopfrom
move-some-ube-injection-code-to-gutenberg-mobile-repo

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Aug 19, 2020 •
edited
Loading

Adding custom js-script for Unsupported Block Fallback to remove wpcom NUX UI.
This script is not used in this repo, but it's here to be used from the client apps.

gutenberg PR: WordPress/gutenberg#24658
WPiOS side PR: wordpress-mobile/WordPress-iOS#14683
WPAndroid side PR: wordpress-mobile/WordPress-Android#12795

To test:

Please refer to wordpress-mobile/WordPress-iOS#14683 for testing steps

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added this to the 1.36 milestone Aug 19, 2020
@etoledom etoledom self-assigned this Aug 19, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Aug 19, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

This was referenced Aug 19, 2020
Merged
Merged
@marecar3
Copy link
Copy Markdown
Contributor

marecar3 commented Aug 25, 2020

Hey 👋 @etoledom
The android part of the fix is ready for testing. Feel free to mark this PR ready for review if you think that we have everything that we wanted to have? thanks.

@marecar3 marecar3 mentioned this pull request Aug 25, 2020
Merged
3 tasks
@marecar3
Copy link
Copy Markdown
Contributor

marecar3 commented Aug 25, 2020

Hey @etoledom 👋
I have updated the description with the WPAndroid side PR.

@cameronvoell
Copy link
Copy Markdown
Contributor

cameronvoell commented Aug 31, 2020

Hey @etoledom please aim to merge this first half of the day 8/31 if we're still aiming for 1.36, otherwise I'll suggest we bump the target 1.37. Thanks!

@etoledom etoledom modified the milestones: 1.36, 1.37 Aug 31, 2020
@etoledom etoledom requested a review from ceyhun September 2, 2020 15:24
@jd-alexander
Copy link
Copy Markdown
Contributor

jd-alexander commented Sep 4, 2020 •
edited
Loading

Hi @etoledom we'll be cutting the 1.37 release branch at the end of next week. Please try to get this merged by then or bump the milestone. Thanks much 🙇

@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Sep 7, 2020

Tested on WPiOS and WPAndroid and this seems to work great in both!

@etoledom etoledom marked this pull request as ready for review September 7, 2020 14:28
mchowning
mchowning approved these changes Sep 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via wordpress-mobile/WordPress-Android#12795 and this is working well. Since @guarani already tested the WPiOS side of this, I think we're good to :shipit:

@jd-alexander
Copy link
Copy Markdown
Contributor

jd-alexander commented Sep 11, 2020

Hi @etoledom we'll be cutting the 1.37 release branch at the beginning of next week. Please try to get this merged by then or bump the milestone. Thanks much 🙇

@etoledom etoledom merged commit 93db884 into develop Sep 14, 2020
@etoledom etoledom deleted the move-some-ube-injection-code-to-gutenberg-mobile-repo branch September 14, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ceyhun ceyhun Awaiting requested review from ceyhun

1 more reviewer

@mchowning mchowning mchowning approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@etoledom etoledom

Labels

None yet

Projects

None yet

Milestone

1.37

Development

Successfully merging this pull request may close these issues.

5 participants

@etoledom @marecar3 @cameronvoell @jd-alexander @mchowning