[Gutenberg] Implement custom JS code injection#12795
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Merged
2 tasks
|
You can test the changes on this Pull Request by downloading the APK here. |
6 tasks
# Conflicts: # libs/gutenberg-mobile
Contributor
|
Hey there! I'm moving this to 15.8 because 15.7 has been already cut! If you want this to make it to 15.7, please feel free to ping me. |
Contributor
Author
|
Hey 👋 @mchowning |
mchowning
approved these changes
Sep 11, 2020
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Code looks good and I tested and it is working well! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # This PR removes some references to window.wp.data.dispatch( 'automattic/nux' ); and "automattic/nux": and implements a mechanism to insert custom JS to be injected from the client.
To test: Follow instructions in gb PR WordPress/gutenberg#24658
gb-mobile PR: wordpress-mobile/gutenberg-mobile#2561
gutenberg PR: WordPress/gutenberg#24658
PR submission checklist:
RELEASE-NOTES.txtif necessary.