Skip to content

[Gutenberg] UBE - Implement custom JS code #14683

Merged
etoledom merged 5 commits intodevelopfrom
gutenberg/ube-custom-js-scripts
Sep 14, 2020
Merged

[Gutenberg] UBE - Implement custom JS code #14683
etoledom merged 5 commits intodevelopfrom
gutenberg/ube-custom-js-scripts

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Aug 19, 2020 •
edited
Loading

gb-mobile PR: wordpress-mobile/gutenberg-mobile#2561
gutenberg PR: WordPress/gutenberg#24658

This PR implements the changes from the previously mentioned PRs.

With these changes we are able to inject custom JS scripts to the Unsupported Block Editor. This is needed to do modifications related to WPCom, that are not allowed to do on gutenberg repo directly.

We inject remove-nux.js and extra-localstorage-entries already provided by gutenberg-mobile�. This will remove the WPCom NUX screen when a new user opens gutenberg for the first time.

To test:

  • Create a new wpcom account.
  • On the newly created site, create a new gutenberg post.
  • On HTML mode, paste this snippet (or any other unsupported block HTML code): <!-- wp:file /-->
  • Go back to visual mode.
  • Open the unsupported block with the Unsupported Block Editor.
  • Check that Gutenberg editor loads without the NUX UI covering it.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Aug 19, 2020
@etoledom etoledom added this to the 15.6 milestone Aug 19, 2020
@etoledom etoledom self-assigned this Aug 19, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Aug 19, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@etoledom etoledom mentioned this pull request Aug 19, 2020
Merged
2 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Aug 19, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jkmassel
Copy link
Copy Markdown
Contributor

jkmassel commented Aug 24, 2020

We're cutting the 15.6 release today, so this PR is being bumped to 15.7. If it needs to land in the 15.6 release, please merge it to the release/15.6 branch, and DM me so that I can release a new beta build.

Thanks!

@jkmassel jkmassel modified the milestones: 15.6, 15.7 Aug 24, 2020
@etoledom etoledom force-pushed the gutenberg/ube-custom-js-scripts branch from 45c6694 to 906737b Compare September 2, 2020 14:24
@etoledom etoledom changed the title [Gutenberg] Implement custom JS code (prev… [Gutenberg] UBE - Implement custom JS code Sep 2, 2020
@etoledom etoledom marked this pull request as ready for review September 2, 2020 15:23
@etoledom etoledom requested a review from ceyhun September 2, 2020 15:23
@etoledom etoledom mentioned this pull request Sep 2, 2020
Merged
6 tasks
@loremattei loremattei modified the milestones: 15.7, 15.8 Sep 7, 2020
@loremattei
Copy link
Copy Markdown
Contributor

loremattei commented Sep 7, 2020

Hey there! I'm moving this to 15.8 because 15.7 has been cut. If you want this to make it to 15.7, please, feel free to ping me.

@etoledom etoledom force-pushed the gutenberg/ube-custom-js-scripts branch from eaf0a42 to 96bc2de Compare September 7, 2020 14:27
@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Sep 7, 2020

Updated with develop and with the latest from wordpress-mobile/gutenberg-mobile#2561

@etoledom etoledom requested a review from guarani September 7, 2020 15:25
@guarani
Copy link
Copy Markdown
Contributor

guarani commented Sep 9, 2020 •
edited
Loading

@etoledom just a headsup that I tried to create an App Center build and it failed, looks like it's due to the changing Podfile.lock.

guarani
guarani approved these changes Sep 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#24658 (review)

@etoledom etoledom force-pushed the gutenberg/ube-custom-js-scripts branch from 96bc2de to b8b5b66 Compare September 14, 2020 07:36
@etoledom etoledom merged commit a468ba6 into develop Sep 14, 2020
@etoledom etoledom deleted the gutenberg/ube-custom-js-scripts branch September 14, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ceyhun ceyhun Awaiting requested review from ceyhun

1 more reviewer

@guarani guarani guarani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@etoledom etoledom

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

15.8

Development

Successfully merging this pull request may close these issues.

4 participants

@etoledom @jkmassel @loremattei @guarani