Skip to content

Add support for full width/wide alignment options#2559

Merged
geriux merged 13 commits intodevelopfrom
feature/full-wide-wide-alignment
Sep 4, 2020
Merged

Add support for full width/wide alignment options#2559
geriux merged 13 commits intodevelopfrom
feature/full-wide-wide-alignment

Conversation

@geriux
Copy link
Copy Markdown
Contributor

@geriux geriux commented Aug 19, 2020 •
edited
Loading

Gutenberg PR -> WordPress/gutenberg#24598
WordPress iOS PR -> wordpress-mobile/WordPress-iOS#14679
WordPress Android PR -> wordpress-mobile/WordPress-Android#12720

Fixes #2463

This PR adds full width / wide alignment options. For the first iteration, it will support only some blocks: Group, Cover, and Image block.

For a more detailed description and test cases, please check the Gutenberg PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the [Type] Enhancement Improves a current area of the editor label Aug 19, 2020
@geriux geriux added this to the 1.36 milestone Aug 19, 2020
This was referenced Aug 19, 2020
Merged
Closed
Closed
@geriux geriux force-pushed the feature/full-wide-wide-alignment branch from 04119de to ad0fc7d Compare August 19, 2020 17:00
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Aug 19, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux force-pushed the feature/full-wide-wide-alignment branch from ad0fc7d to f7e57a9 Compare August 21, 2020 11:54
@geriux geriux force-pushed the feature/full-wide-wide-alignment branch from 7311afa to 6a1d42a Compare August 24, 2020 15:27
@iamthomasbishop iamthomasbishop mentioned this pull request Aug 25, 2020
Closed
@geriux geriux force-pushed the feature/full-wide-wide-alignment branch from 6a1d42a to d37d4d5 Compare August 26, 2020 11:37
@geriux geriux force-pushed the feature/full-wide-wide-alignment branch from d37d4d5 to 74d8121 Compare August 27, 2020 13:43
@geriux geriux force-pushed the feature/full-wide-wide-alignment branch from 74d8121 to 2b8afd3 Compare August 27, 2020 15:16
@geriux geriux force-pushed the feature/full-wide-wide-alignment branch from 2b8afd3 to d5524be Compare August 28, 2020 14:49
@geriux geriux removed this from the 1.36 milestone Aug 28, 2020
@geriux geriux requested a review from lukewalczak August 28, 2020 16:57
@geriux geriux marked this pull request as ready for review August 28, 2020 16:57
@geriux geriux force-pushed the feature/full-wide-wide-alignment branch from d5524be to 5d6e83f Compare September 2, 2020 10:52
lukewalczak
lukewalczak approved these changes Sep 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via gutenberg PR!

@geriux geriux force-pushed the feature/full-wide-wide-alignment branch from 5d6e83f to bf24264 Compare September 4, 2020 10:48
@geriux geriux added this to the 1.37 milestone Sep 4, 2020
@geriux geriux merged commit f83a487 into develop Sep 4, 2020
@geriux geriux deleted the feature/full-wide-wide-alignment branch September 4, 2020 11:18
@geriux geriux mentioned this pull request Sep 9, 2020
Closed
2 tasks
@ceyhun ceyhun mentioned this pull request Sep 14, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lukewalczak lukewalczak lukewalczak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

1.37

Development

Successfully merging this pull request may close these issues.

Add support for wide/full-width Alignment options

2 participants

@geriux @lukewalczak