Skip to content

Correct slider step value#2119

Merged
pinarol merged 3 commits intodevelopfrom
correct-slider-step
Apr 13, 2020
Merged

Correct slider step value#2119
pinarol merged 3 commits intodevelopfrom
correct-slider-step

Conversation

@lukewalczak
Copy link
Copy Markdown
Contributor

Fixes #2117
Ref to gutenberg: WordPress/gutenberg#21451

To test:

Open mobile app
Add spacer block
Open spacer settings
Move slider
Expect that step value is 1

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak self-assigned this Apr 7, 2020
@lukewalczak lukewalczak added Blocks Web breakage Caused by incompatible changes on Gutenberg web labels Apr 7, 2020
@pinarol pinarol added this to the 1.26 milestone Apr 13, 2020
Copy link
Copy Markdown
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinarol pinarol merged commit 8a090f2 into develop Apr 13, 2020
@pinarol pinarol deleted the correct-slider-step branch April 13, 2020 12:19
pinarol added a commit that referenced this pull request Apr 16, 2020
* Add tests for Latest-Posts Bock

* Have the Automation tests Scroll the Block window to help locate Block buttons on Android

* Update gutenberg reference

* Update Gutenberg ref

* Update Gutenberg ref

* New template for release PRs

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

* Update template file.

* Fix: remove extra padding for post title and first `Paragraph` block (#2095)

* Fix: remove extra padding for post title and first `Paragraph` block

* Update Gutenberg ref

* Add a new androidReplacements function to comply with Android Typography lint rules

* Make sure the file gutenberg.pot exists before generating android and ios strings.

* Update Gutenberg ref

* Update gutenberg ref

* Update gutenberg ref

* Update gutenberg reference

* Gutenberg update

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS

* Update Gutenberg ref

* Update Gutenberg ref

* Accept multiple headers through OnAuthHeaderRequestedListener (#2080)

* Blog layout template (#2114)

* Update Gutenberg ref

* Update Gutenberg ref

* Update gutenberg reference

* Fix failing UI tests

Try scrolling in the Inserter for all platforms

* Disable the failing test on iOS

Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* Update gutenberg reference

* Feat: Column block (#1661)

* update ref to master (Columns Block)

* Update gutenberg reference

* Fix Latests Posts Tests by expanding the scroll to button functionality

* Fix lint issue

* Fix typography breakage in master

To a version where the typography panel is not added to block settings.

* Update GB reference.

* Correct slider step value (#2119)

* Update ref: Correct slider step accordingly to the platform

* Update gb ref

Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* v1.26.0

* Add some missing release notes

* Update Podfile.lock

* Update gb ref

* Update bundles

Co-authored-by: Chip Snyder <chip.snyder3@gmail.com>
Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: jbinda <jakub.binda@gmail.com>
Co-authored-by: Chip <chip.snyder@automattic.com>
Co-authored-by: Maxime Biais <maxime.biais@gmail.com>
Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com>
Co-authored-by: Klymentiy Haykov <forsver@gmail.com>
Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
pinarol added a commit that referenced this pull request Apr 16, 2020
* Release v1.26.0 (#2153)

* Add tests for Latest-Posts Bock

* Have the Automation tests Scroll the Block window to help locate Block buttons on Android

* Update gutenberg reference

* Update Gutenberg ref

* Update Gutenberg ref

* New template for release PRs

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

* Update template file.

* Fix: remove extra padding for post title and first `Paragraph` block (#2095)

* Fix: remove extra padding for post title and first `Paragraph` block

* Update Gutenberg ref

* Add a new androidReplacements function to comply with Android Typography lint rules

* Make sure the file gutenberg.pot exists before generating android and ios strings.

* Update Gutenberg ref

* Update gutenberg ref

* Update gutenberg ref

* Update gutenberg reference

* Gutenberg update

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS

* Update Gutenberg ref

* Update Gutenberg ref

* Accept multiple headers through OnAuthHeaderRequestedListener (#2080)

* Blog layout template (#2114)

* Update Gutenberg ref

* Update Gutenberg ref

* Update gutenberg reference

* Fix failing UI tests

Try scrolling in the Inserter for all platforms

* Disable the failing test on iOS

Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* Update gutenberg reference

* Feat: Column block (#1661)

* update ref to master (Columns Block)

* Update gutenberg reference

* Fix Latests Posts Tests by expanding the scroll to button functionality

* Fix lint issue

* Fix typography breakage in master

To a version where the typography panel is not added to block settings.

* Update GB reference.

* Correct slider step value (#2119)

* Update ref: Correct slider step accordingly to the platform

* Update gb ref

Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* v1.26.0

* Add some missing release notes

* Update Podfile.lock

* Update gb ref

* Update bundles

Co-authored-by: Chip Snyder <chip.snyder3@gmail.com>
Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: jbinda <jakub.binda@gmail.com>
Co-authored-by: Chip <chip.snyder@automattic.com>
Co-authored-by: Maxime Biais <maxime.biais@gmail.com>
Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com>
Co-authored-by: Klymentiy Haykov <forsver@gmail.com>
Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>

* Update gb ref

Co-authored-by: Chip Snyder <chip.snyder3@gmail.com>
Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: jbinda <jakub.binda@gmail.com>
Co-authored-by: Chip <chip.snyder@automattic.com>
Co-authored-by: Maxime Biais <maxime.biais@gmail.com>
Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com>
Co-authored-by: Klymentiy Haykov <forsver@gmail.com>
Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocks Web breakage Caused by incompatible changes on Gutenberg web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slider component only allows adjusting in increments of 10 via drag gesture

2 participants