Accept multiple headers through OnAuthHeaderRequestedListener#2080
Merged
Accept multiple headers through OnAuthHeaderRequestedListener#2080
Conversation
3 tasks
…e into feature/accept-multiple-headers-for-request
…e into feature/accept-multiple-headers-for-request
Contributor
Author
|
@mchowning Thank you for the review! Sorry, I'm not sure what is the process for merging PR's in this repo. Should I do it? Also, how do we ensure the client-side changes will be included with the release? Should I target the client-side PR towards future GB release integration branch? |
Contributor
In this repo, if there is no assignee anyone can merge. In practice though, the author of the PR almost always does the merge, which is why I didn't merge (to be completely honest, I didn't even think about it). I'll go ahead and merge this now though since there's no assignee. 😄 I'll leave the WPAndroid PR for you though since it needs be updated with the merged gutenberg-mobile hash (or if you'd like me to merge after you make that update, just ping me 🙂 ).
Everything that is included in the |
pinarol
added a commit
that referenced
this pull request
Apr 16, 2020
* Add tests for Latest-Posts Bock * Have the Automation tests Scroll the Block window to help locate Block buttons on Android * Update gutenberg reference * Update Gutenberg ref * Update Gutenberg ref * New template for release PRs This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs. This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md` * Update template file. * Fix: remove extra padding for post title and first `Paragraph` block (#2095) * Fix: remove extra padding for post title and first `Paragraph` block * Update Gutenberg ref * Add a new androidReplacements function to comply with Android Typography lint rules * Make sure the file gutenberg.pot exists before generating android and ios strings. * Update Gutenberg ref * Update gutenberg ref * Update gutenberg ref * Update gutenberg reference * Gutenberg update * Update Gutenberg ref * Update Gutenberg ref * Update Gutenberg ref * Update Gutenberg ref * Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023) * prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS * Update Gutenberg ref * Update Gutenberg ref * Accept multiple headers through OnAuthHeaderRequestedListener (#2080) * Blog layout template (#2114) * Update Gutenberg ref * Update Gutenberg ref * Update gutenberg reference * Fix failing UI tests Try scrolling in the Inserter for all platforms * Disable the failing test on iOS Co-authored-by: Matthew Kevins <mmkevins@yahoo.com> Co-authored-by: Pinar Olguc <pinarolguc@gmail.com> * Update gutenberg reference * Feat: Column block (#1661) * update ref to master (Columns Block) * Update gutenberg reference * Fix Latests Posts Tests by expanding the scroll to button functionality * Fix lint issue * Fix typography breakage in master To a version where the typography panel is not added to block settings. * Update GB reference. * Correct slider step value (#2119) * Update ref: Correct slider step accordingly to the platform * Update gb ref Co-authored-by: Pinar Olguc <pinarolguc@gmail.com> * v1.26.0 * Add some missing release notes * Update Podfile.lock * Update gb ref * Update bundles Co-authored-by: Chip Snyder <chip.snyder3@gmail.com> Co-authored-by: Matthew Kevins <mmkevins@yahoo.com> Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com> Co-authored-by: jbinda <jakub.binda@gmail.com> Co-authored-by: Chip <chip.snyder@automattic.com> Co-authored-by: Maxime Biais <maxime.biais@gmail.com> Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com> Co-authored-by: Klymentiy Haykov <forsver@gmail.com> Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com> Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
pinarol
added a commit
that referenced
this pull request
Apr 16, 2020
* Release v1.26.0 (#2153) * Add tests for Latest-Posts Bock * Have the Automation tests Scroll the Block window to help locate Block buttons on Android * Update gutenberg reference * Update Gutenberg ref * Update Gutenberg ref * New template for release PRs This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs. This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md` * Update template file. * Fix: remove extra padding for post title and first `Paragraph` block (#2095) * Fix: remove extra padding for post title and first `Paragraph` block * Update Gutenberg ref * Add a new androidReplacements function to comply with Android Typography lint rules * Make sure the file gutenberg.pot exists before generating android and ios strings. * Update Gutenberg ref * Update gutenberg ref * Update gutenberg ref * Update gutenberg reference * Gutenberg update * Update Gutenberg ref * Update Gutenberg ref * Update Gutenberg ref * Update Gutenberg ref * Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023) * prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS * Update Gutenberg ref * Update Gutenberg ref * Accept multiple headers through OnAuthHeaderRequestedListener (#2080) * Blog layout template (#2114) * Update Gutenberg ref * Update Gutenberg ref * Update gutenberg reference * Fix failing UI tests Try scrolling in the Inserter for all platforms * Disable the failing test on iOS Co-authored-by: Matthew Kevins <mmkevins@yahoo.com> Co-authored-by: Pinar Olguc <pinarolguc@gmail.com> * Update gutenberg reference * Feat: Column block (#1661) * update ref to master (Columns Block) * Update gutenberg reference * Fix Latests Posts Tests by expanding the scroll to button functionality * Fix lint issue * Fix typography breakage in master To a version where the typography panel is not added to block settings. * Update GB reference. * Correct slider step value (#2119) * Update ref: Correct slider step accordingly to the platform * Update gb ref Co-authored-by: Pinar Olguc <pinarolguc@gmail.com> * v1.26.0 * Add some missing release notes * Update Podfile.lock * Update gb ref * Update bundles Co-authored-by: Chip Snyder <chip.snyder3@gmail.com> Co-authored-by: Matthew Kevins <mmkevins@yahoo.com> Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com> Co-authored-by: jbinda <jakub.binda@gmail.com> Co-authored-by: Chip <chip.snyder@automattic.com> Co-authored-by: Maxime Biais <maxime.biais@gmail.com> Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com> Co-authored-by: Klymentiy Haykov <forsver@gmail.com> Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com> Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> * Update gb ref Co-authored-by: Chip Snyder <chip.snyder3@gmail.com> Co-authored-by: Matthew Kevins <mmkevins@yahoo.com> Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com> Co-authored-by: jbinda <jakub.binda@gmail.com> Co-authored-by: Chip <chip.snyder@automattic.com> Co-authored-by: Maxime Biais <maxime.biais@gmail.com> Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com> Co-authored-by: Klymentiy Haykov <forsver@gmail.com> Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com> Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
OkHttpHeaderInterceptorto be more generic, and move the header setting logic to the client. It also adds the ability to utilize multiple headers passed from the client.You can test it with Client side PR.
PR submission checklist:
RELEASE-NOTES.txtif necessary.