Skip to content

Release v1.19.1#1710

Merged
malinajirka merged 3 commits intomasterfrom
feature/add_content_watcher_to_aztec
Jan 10, 2020
Merged

Release v1.19.1#1710
malinajirka merged 3 commits intomasterfrom
feature/add_content_watcher_to_aztec

Conversation

@planarvoid
Copy link
Copy Markdown
Contributor

@planarvoid planarvoid commented Dec 20, 2019 •
edited by malinajirka
Loading

This PR points to changes in Aztec. These changes don't touch any existing interfaces and only add new functionality so they shouldn't break anything.
Aztec changes - wordpress-mobile/AztecEditor-Android@807062a

We only want to merge this once the Aztec version is released.
Did I update the GB version correctly @hypest ?

Related PRs

Test Plan

  • There is nothing to tests since this is only a new interface not used anywhere in the code yet

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@planarvoid planarvoid added the [Type] Enhancement Improves a current area of the editor label Dec 20, 2019
@planarvoid planarvoid requested a review from hypest December 20, 2019 13:16
@planarvoid planarvoid self-assigned this Dec 20, 2019
@marecar3 marecar3 self-requested a review December 20, 2019 13:23
@marecar3
Copy link
Copy Markdown
Contributor

marecar3 commented Dec 20, 2019

Hey @planarvoid 👋
Maybe I can help with all your questions.

Did I update the GB version correctly @hypest?

Yes, it seems that it's correct.

Regarding this PR I have some comments:

  • We usually set the title of the PR to match release version: e.g. Release v1.19.1
  • Also, we set the label release-process
  • And usually, branch name should match the version of the release and it should have prefix release

You can see a nice pattern here: #1627

Note: We should also reference proper WPAndroid PR which will update WPAndroid app with the new version of aztec and especially a new version of the gb-mobile.

Hey @etoledom, not sure if we need to update WPiOS as with 1.19.1 we are just updating the android aztec, what's your impression? Thanks!

@planarvoid planarvoid changed the title Update Aztec version to contain the content watcher Release v1.19.1 Jan 2, 2020
@planarvoid
Copy link
Copy Markdown
Contributor Author

planarvoid commented Jan 2, 2020

Hey @marecar3,
thanks for the check, I've renamed the PR, set the label and added a link to the Aztec changes. I don't have a PR for the WPAndroid merge of Gutenberg release since I don't know how that's done. Do you think you could help me with that? I also don't think it's very important to have this release in WPAndroid or WPiOS since there are no changes to the current logic.

@hypest
Copy link
Copy Markdown
Contributor

hypest commented Jan 9, 2020 •
edited
Loading

The Android device tests are failing (on da41861) because of #1703, which is not related to the changes in this PR.

@malinajirka malinajirka mentioned this pull request Jan 10, 2020
Merged
2 tasks
malinajirka
malinajirka approved these changes Jan 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@malinajirka malinajirka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anitaa and I have tested the changes in WPAndroid and everything seems to work as expected!

I merging this even though one of the tests is failing as it's not caused by this PR -> 🚢

@malinajirka malinajirka merged commit 3ee93dd into master Jan 10, 2020
@malinajirka malinajirka deleted the feature/add_content_watcher_to_aztec branch January 10, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malinajirka malinajirka malinajirka approved these changes

@hypest hypest Awaiting requested review from hypest

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees

@planarvoid planarvoid

Labels

release-process [Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@planarvoid @marecar3 @hypest @malinajirka