Skip to content

Gutenberg and Aztec update - add content watcher to aztec#11065

Merged
malinajirka merged 3 commits intodevelopfrom
gutenberg/add_content_watcher_to_aztec
Jan 10, 2020
Merged

Gutenberg and Aztec update - add content watcher to aztec#11065
malinajirka merged 3 commits intodevelopfrom
gutenberg/add_content_watcher_to_aztec

Conversation

@malinajirka
Copy link
Copy Markdown
Contributor

@malinajirka malinajirka commented Jan 10, 2020

This PR updates Aztec (both the built in editor and gutenberg which uses Aztec internally). The only change in Aztec is introduction of a content watcher which notifies clients about all changes to the content - including changes to spans.

Aztec PR - wordpress-mobile/AztecEditor-Android#887
Gutenberg-mobile PR - wordpress-mobile/gutenberg-mobile#1710

To test:

  • The content watcher isn't being used yet, so just smoke test gutenberg and aztec editors -> eg. add some text + an image to the content.

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 10, 2020

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Copy Markdown
Contributor

@anitaa1990 anitaa1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link
Copy Markdown
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well 👍

@malinajirka malinajirka merged commit 6df7f06 into develop Jan 10, 2020
@malinajirka malinajirka deleted the gutenberg/add_content_watcher_to_aztec branch January 10, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants