Merged
Conversation
malinajirka
approved these changes
Dec 19, 2019
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @planarvoid! The changes look great;).
I really like the "garbage collection" test ❤️ !
Feel free to merge it when the lint issue is fixed 🚢
2 tasks
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to register an observer for all the changes to the
AztecTextobject. This is used to save the content on every content change. Pure TextWatcher doesn't work for the span changes and this solution should work for everything. I've added unit tests to test the new content change watcher.Make sure strings will be translated:
strings.xmlas a part of the integration PR.