Skip to content

Add image size picker improvements#1574

Closed
cameronvoell wants to merge 11 commits intodevelopfrom
add/image-size-picker-improvements
Closed

Add image size picker improvements#1574
cameronvoell wants to merge 11 commits intodevelopfrom
add/image-size-picker-improvements

Conversation

@cameronvoell
Copy link
Copy Markdown
Contributor

@cameronvoell cameronvoell commented Nov 13, 2019 •
edited
Loading

Fixes #1452

Companion PR's

Gutenberg PR: WordPress/gutenberg#19232
WPiOS PR (for testing): wordpress-mobile/WordPress-iOS#13052

Changes

  • Introduces cycle button UI for updating the size of an image from the BottomSheet menu in an Image Block.
  • Removes duplicated default image size declarations and instead utilizes image sizes from the editor settings data store.

Screenshots

size-changes

See this comment and above comments for context: WordPress/gutenberg#17245 (review)

To Test:

  1. Navigate to the Block Editor
  2. Add an Image Block and upload an image
  3. Click the gear for block settings
  4. Tap Image Size row and verify value cycles through available sizes (Thumbnail, Medium, Large, Fullscreen).
  5. Verify the Image size changes as you click through the menu.
  6. Verify the Image Size is preserved if you update the post, leave, and return.

*Note this PR is mainly covering UI updates, for Image Size error handling with updating URL's from the network etc, see this issue: #1593

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@cameronvoell cameronvoell changed the title Add/image size picker improvements Add image size picker improvements Nov 13, 2019
@cameronvoell cameronvoell mentioned this pull request Nov 13, 2019
Closed
8 tasks
@hypest
Copy link
Copy Markdown
Contributor

hypest commented Nov 29, 2019

👋 Cameron, is this PR still relevant? If yes, let's retarget it, thanks!

@cameronvoell cameronvoell changed the base branch from release/1.17 to develop December 3, 2019 00:02
@cameronvoell cameronvoell mentioned this pull request Dec 19, 2019
Merged
6 tasks
@cameronvoell cameronvoell force-pushed the add/image-size-picker-improvements branch from c898818 to a93dd36 Compare December 19, 2019 06:10
@cameronvoell cameronvoell added this to the 1.20 milestone Dec 19, 2019
@cameronvoell cameronvoell added Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile Media labels Dec 19, 2019
@cameronvoell cameronvoell marked this pull request as ready for review December 19, 2019 07:01
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Dec 19, 2019

Thank you @cameronvoell for the update!

@iamthomasbishop - What do you think about this (temporal) solution for the Image Sizes picker?

size-changes

@iamthomasbishop
Copy link
Copy Markdown
Contributor

iamthomasbishop commented Dec 19, 2019

@etoledom @cameronvoell It looks pretty solid overall, based on the test build I grabbed here. One thing I noticed is that the first time you switch to each different size, the background container (with the image block icon and light gray background) is displayed at full size for a split second. Video for reference: https://cloudup.com/c642ckhMCez

@cameronvoell
Copy link
Copy Markdown
Contributor Author

cameronvoell commented Jan 8, 2020 •
edited
Loading

One thing I noticed is that the first time you switch to each different size, the background container (with the image block icon and light gray background) is displayed at full size for a split second.

@iamthomasbishop The improvements from this fix should make this much less jarring, especially in dark mode.

@etoledom etoledom modified the milestones: 1.20, 1.22 Jan 20, 2020
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Jan 20, 2020

Moved milestone to v1.22.
Please feel free to re-target if you consider this PR must be shipped together with v1.21.

@cameronvoell cameronvoell force-pushed the add/image-size-picker-improvements branch from c35ad56 to 9a23135 Compare February 3, 2020 09:34
@cameronvoell cameronvoell modified the milestones: 1.22, 1.23 Feb 7, 2020
etoledom
etoledom approved these changes Feb 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🎉

@cameronvoell
Copy link
Copy Markdown
Contributor Author

cameronvoell commented Feb 14, 2020

closing as gutenberg changes were brought in to gb-mobile through another PR (still under DEV flag).

See this PR for removing DEV flag and updating release notes for this feature: #1904

@etoledom etoledom deleted the add/image-size-picker-improvements branch February 14, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchowning mchowning Awaiting requested review from mchowning

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile Media

Projects

None yet

Milestone

1.23

Development

Successfully merging this pull request may close these issues.

Image Block Size Options - UX Production Ready

4 participants

@cameronvoell @hypest @etoledom @iamthomasbishop