[RNMobile] Fix media upload placeholder#19497
Merged
cameronvoell merged 4 commits intomasterfrom Jan 13, 2020
Merged
Conversation
2 tasks
etoledom
reviewed
Jan 9, 2020
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Looks and works great! Thank you for this @cameronvoell 🎉
Added a small code comment but it's just a small detail. 👍
Comment on lines
+63
to
+66
| .iconUploadDark { | ||
| fill: $gray-70; | ||
| width: 100%; | ||
| height: 100%; |
Contributor
There was a problem hiding this comment.
In the dark version of the style we don't need to re-define other than the color properties. All properties that are the same will be copied from the light version.
(Same for all other Dark style definitions)
etoledom
approved these changes
Jan 13, 2020
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Thank you for the update @cameronvoell
Great job! 🎉
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes gutenberg-mobile #1544
This change refines the mobile image and video block placeholder shown during upload.
How has this been tested?
See gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1757
Uploading images can be tested using the WordPress Android and iOS apps using the following steps:
Screenshots
Placeholders before the change:
After Change
Video:
Types of changes
This change is introducing deliberate, consistent styles for both light and dark mode for image and video placeholder icons and backgrounds during upload.
There is also a small refactor for fetching icons in an easier to comprehend way and removing unreachable code.
Checklist: