Conversation
…om_web Incorporate ListEdit change from web
Extract caption component
Adding additional error messaging because with the `--list-different` flag (which is needed to force a non-zero exit code) and without the `--write` flag (which would cause a 0/successful exit code) the default error messaging confusingly says both success and error.
…placed Hide block if being replaced
Fix initial html after changes to text alignment
…tier_on_ci Enforce Prettier (add CI and pre-commit hook)
Master 1.11.0 to develop
* update ref * update ref * update ref * Merge branch 'develop' into callstack/media-upload-props * change git submodule url * update ref
Recover border color on focused blocks
…rg-mobile into try/device-tests
Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.2. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.3.1...v1.4.2) Signed-off-by: dependabot[bot] <support@github.com>
Try/device tests
* Add ref to PR #17251 from gutenberg * update ref * update ref * update ref * Update to the latest rnmobile/master
marecar3
left a comment
There was a problem hiding this comment.
LGTM!
Nice work @mchowning
| * Prevent keyboard dismissal when switching between caption and text block on Android | ||
| * Blocks that would be replaced are now hidden when add block bottom sheet displays | ||
| * Tapping on empty editor area now always inserts new block at end of post | ||
|
|
There was a problem hiding this comment.
Not sure if we are missing Media&Text and Group blocks from this list, or we want to hide them in 1.12.0 release?
There was a problem hiding this comment.
I confirmed with @etoledom that we do not want either of those blocks to be available in this release, and they are guarded by a dev flag.
I also made release builds of both iOS and Android and confirmed that those blocks are not selectable from the bottom modal block picker and if a post is shown on mobile that contains those blocks (created on the web), then the app just displays a block placeholder. Sounds like you were observing something different though, would you like to double-check this before we merge @marecar3 ?
There was a problem hiding this comment.
Thanks @mchowning for confirmation.
It's always good to check it :)
There was a problem hiding this comment.
It's always good to check it :)
Absolutely! Thanks for bringing it up!
Merging release/1.12.0 branch into master
Remaining work
rnmobile/release-1.12.0hasn't been updated since it was branched off ofrnmobile/master(branch comparison).Please let me know if you think I am missing any steps⤴️