@dratwas Could you please put the link of the associated gutenberg PR in the description please? Thanks!

Thanks for the PR! I'll start reviewing this but, a couple of things that caught my attention:

I think the .gitmodules file needs this change in order for reviewers to see your fork's changes:

But this should be reverted before the merge ☝️

Secondly, you should commit & push gutenberg subrepo hash to this PR after you pushed things to the gutenberg PR.

That way reviewer can checkout the PR branch and start testing right after just running a submodule update.

I tried checking it out locally and it worked for me, even if it fails in CI. I think github exposes external commits that are part of a PR when fetching somehow. My guess is that it might be something that only works on newer git clients, but I don’t really know how that’s working.

To me it was confusing and limiting. First of all I got an error on checkout so it left me with some question marks about having the right things to test. Our CI has the same error: Fetched in submodule path 'gutenberg', but it did not contain 23ab43f458464675aef9fe10b13796e24bf4b9b3. Direct fetching of that commit failed. I wanted to go to the subrepo and check if I have the updated version of the branch but I couldn't checkout the remote branch because it didn't exist. After changing my subrepo config I was able to do this and realized that this PR had the old hash pointing to gutenberg repo.

I think it would contain less confusion that way and CI jobs would also succeed hopefully.

WordPress/gutenberg#17145 was just merged

After the gutenberg PR is merged please update the gutenberg submodule ref to point to rnmobile/master and revert the .gitmodules file.

Done :)

● Gutenberg Editor paste tests › copies styled text from one paragraph block and pastes in another

@etoledom is this the failing UI test you were referring to ? if so I'll merge this one.

@dratwas Could you be able to update gutenberg subrepo again to point to the latest rnmobile/master ? We just merged and WordPress/gutenberg#17268 it is related with this work

@etoledom is this the failing UI test you were referring to ? if so I'll merge this one.

Yes, it looks like it. The best way to be sure is to run them locally though.

I ran Android UI tests(yarn test:e2e:android:local) locally by updating __device-tests__/helpers/caps.js > deviceName: 'Pixel 2 XL API 28' since that's the one available in my local.

They look fine:

Test Suites: 8 passed, 8 total
Tests:       21 passed, 21 total
Snapshots:   0 total
Time:        524.039s
Ran all test suites.
✨  Done in 581.71s.