Add "Autosave" bridge methods and enable local auto-save of posts#1351
Add "Autosave" bridge methods and enable local auto-save of posts#1351daniloercoli merged 13 commits intodevelopfrom
Conversation
…rg-mobile into add/autosave-monitor * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (56 commits) Update gutenberg ref Update gutenberg ref Update gutenberg ref Update gutenberg ref Add support for group component (#1335) Update gutenberg hash fix error generating app name on sauce Bump eslint-utils from 1.3.1 to 1.4.2 Update gutenberg ref Update release notes Update gutenberg ref to rnmobile/master HEAD disable paste tests MediaUpload and MediaPlaceholder unify props (#1310) Update gutenberg ref (#1340) Update gutenberg ref disable list tests and enable paste tests enable list tests enable list end tests enable block insertion tests enable heading tests ... # Conflicts: # gutenberg
There was a problem hiding this comment.
Tested this on Pixel 3a, and it fixes the issue as described.
Looks good! Nice work @daniloercoli ! 🎉
|
Just adding: gb companion PR link: WordPress/gutenberg#17329 |
marecar3
left a comment
There was a problem hiding this comment.
Nice work @daniloercoli !
Working as expected!
|
Added the iOS side: 4b9881f I also created the WPiOS side PR: wordpress-mobile/WordPress-iOS#12489 In what version we want to ship this? If that's not the case, we won't be able to merge the WPiOS PR until its own next code freeze, since these changes has breaking changes. |
|
Don't forget to generate new bundles before merging this, I went to test the iOS PR and I kept wondering why it wasn't working 😅 |
I think we should not touch the frozen branch. So for both iOS and Android we need to wait until next code freeze. |
…rg-mobile into add/autosave-monitor * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: [iOS]Fix: Oddly formatted text hangs Gutenberg (#1352) Remove redundant bg color within button appender (#1348) Update bundles Update package.json version to 1.12.0 # Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/ios/App.js # bundle/ios/App.js.map
Fixes wordpress-mobile/WordPress-Android#10415
This PR adds the required bridge methods to Android that are used to link the GB side with the native side, and enable auto-save triggered from the GB side.
To tests this PR, follow the instruction on the following wp-android PR: wordpress-mobile/WordPress-Android#10483
cc @etoledom Once the approach is validated we should add the iOS code before merging this PR.
Edit:
WPiOSPR: wordpress-mobile/WordPress-iOS#12489gutenbergPR: WordPress/gutenberg#17329RELEASE-NOTES.txt.