Fix for local auto save that doesn't work in Gutenberg#10483
Merged
daniloercoli merged 6 commits intogb/release-1.13.0from Sep 19, 2019
Merged
Conversation
1 task
|
You can test the changes on this Pull Request by downloading the APK here. |
mkevins
reviewed
Sep 5, 2019
Contributor
There was a problem hiding this comment.
I tested this on Pixel 3a, and it fixes the issue as described 🎉 !
One note:
I did not observe the line described in the original issue being invoked. Still, the changes were saved locally, when I followed the steps there, after applying the fix in this PR.
I placed a breakpoint on that line, and it was touched, when the post is opened, but that also occurs before the fix. 🤷♂️ Is that expected?
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Outdated
Show resolved
Hide resolved
marecar3
approved these changes
Sep 5, 2019
Contributor
marecar3
left a comment
There was a problem hiding this comment.
Nice work!
Working as expected!
1 task
…ss-Android into fix/10415-Local-auto-save-doesnt-work-in-Gutenberg * 'develop' of https://github.com/wordpress-mobile/WordPress-Android: (81 commits) Update gutenberg-mobile ref to v1.12.0 release Update FluxC to the tagged version Update FluxC version to 1.4.0-beta-1 Update release notes from gutenberg-mobile 1.12.0 release Update metadata translations for 13.2 Bump version number Updates translations revert IDE change to Project.xml revert IDE change to Project.xml Hide Sharing manage options for non-admins Removed unused attribute. Add Other post type to posts and pages Show an empty screen when all insights are removed Fix release notes Logic fixes based on the PR feedback Address PR comments fix small lint errors Removed exit transition and ActivityCompat call. Removed slide from left animation. use viewinteraction for choosing options menu ... # Conflicts: # libs/gutenberg-mobile
2 tasks
mchowning
added a commit
that referenced
this pull request
Sep 23, 2019
1 task
mchowning
added a commit
that referenced
this pull request
Sep 23, 2019
…ase_note Add release notes for local autosave from #10483
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10415 by signaling to the host app that changes has been made in GB.
The app then, once received the event, follow the normal flow already implemented for Aztec: asks the content and title to the editor and check for changes.
To test: Follow the steps in the original issue.
GB-Mobile PR: wordpress-mobile/gutenberg-mobile#1351
Update release notes:
RELEASE-NOTES.txtif necessary.