Hardcode link text color in Android#1109
Merged
SergioEstevao merged 2 commits intoissue/697_change_color_of_text_and_linksfrom Jun 10, 2019
Merged
Conversation
SergioEstevao
approved these changes
Jun 10, 2019
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
Working well! Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does implement the Android side of the PR here #1086 by making an hardcode reference to the default GB link color.
As agreed in Slack conversation, this is a required hack for Android until we find a better solution that works fine on all devices without requiring a repaint of the screen. Ref: #1106 and #1101
Follow testing steps here: #1086 (comment).
Update release notes:
RELEASE-NOTES.txt.