Implement link text color as a stand-alone ReactProp in Android#1106
Closed
mkevins wants to merge 6 commits intoissue/697_change_color_of_text_and_linksfrom
Conversation
This reverts commit 5453a7b.
Contributor
|
Reporting here my finding already discussed in a Slack convo. Tested Android 9/Samsung S9 and on Android 7.1/Nexus 5X:
(Note that links turned red, because I've set that color that stands out as default for links). |
Contributor
Author
|
This PR has been superseded by a hard-coded solution: #1109 since the stand-alone prop has inconsistent results on some devices (on some devices, the color / style changes require an additional repaint to take effect). |
Contributor
|
Thanks @mkevins, I will close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the Android side of this PR: #1086
This work is based on and supersedes @marecar3's work in this PR: #1101 but the changes on the Gutenberg side for that PR are no longer necessary for this PR. This PR's Gutenberg companion PR is the same as its target: WordPress/gutenberg#16016.
This PR will also need a new Aztec release after this Aztec PR is merged: wordpress-mobile/AztecEditor-Android@26aaa61, so that the
build.gradlecan reference a tag, rather than a hash.To test:
Follow testing steps here: #1086 (comment).
Optionally, change the values temporarily here: https://github.com/wordpress-mobile/gutenberg-mobile/pull/1086/files#diff-7a9f35e48834f298dc343aeea78d0778R99 to something that stands out (like #ff0000) and see that the changes take effect.