Issue/697 change color of text and links#1086
Conversation
|
@daniloercoli or @mkevins I need help to support the link color on Android. It would also be nice to add underlines to links on Android. |
# Conflicts: # gutenberg
iamthomasbishop
left a comment
There was a problem hiding this comment.
Looks great on the design side! Once we get Android set up, feel free to ping me for review. 
etoledom
left a comment
There was a problem hiding this comment.
Looks good on iOS! ✅
On Android the text color is set but the links color are not changing.
(I'm not the best to asses color though, being colorblind)
Maybe we can have this change on the release notes too? 🤔
Since is a user facing change.
Let's 🚢 after Android is ready to go
|
Would it be worth it to ship this one for iOS and add a ticket to handle the Android side on a separated PR? 🤔 |
|
@etoledom I think so, but I’m not sure what the timeline of getting this to work on Android is looking like. |
|
@marecar3 do you think you can handle this? |
|
Hey @SergioEstevao, I am not sure what is the scope of the work regarding Android, let me check and I will be back with some comment. Tnx. |
# Conflicts: # gutenberg # react-native-aztec/ios/Cartfile # react-native-aztec/ios/Cartfile.resolved
…lo-hardcode_color_links Hardcode link text color in Android
|
@etoledom Android part merged in, do you want to give it another look?
|
etoledom
left a comment
There was a problem hiding this comment.
Looking great! 🎉
There is just one small detail on Android:
The dots... but I guess that is story for another day 😆
Let's !
|
@etoledom I noticed that bullet color too but haven't had a chance to submit a new issue. Would you mind creating an issue for this? 🙃 |
# Conflicts: # gutenberg
|
@iamthomasbishop ready! |
|
@etoledom thank you! |
Fixes #697
Related GB PR: WordPress/gutenberg#16016
This PR updates the RCTAztecView component to support the setting of base text color and the color for links.
To test:
Update release notes:
RELEASE-NOTES.txt.