Merged
Conversation
Cocoapods keeps trying to update it when changing other stuff, so update it on a separate commit in preparation for some other pod changes
This reverts commit 137f0af.
Mae sure any keychain item with the kSecAttrAccessibleWhenUnlocked is updated to kSecAttrAccessibleAfterFirstUnlock so we don't break when waking up from a notification fixes #306
Contributor
There was a problem hiding this comment.
Is this fix required to finish before doing stuff like doing the push notification registration?
Member
Author
There was a problem hiding this comment.
I don't think so. What is required is that a user manually launches the app after update.
There could still be the case that the app auto updates, and it gets launched from a push notification before user interaction.
In that case, I believe the fixKeychainAccess method would just get an errSecInteractionNotAllowed error and return.
So it doesn't fix 100% of the cases on update, but eventually will. To handle that other case, there's https://gist.github.com/koke/7238985 but I haven't tested it that much
Contributor
|
👍 |
Contributor
|
@koke I think this looks good. Merge time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #306:
kSecAttrAccessibleAfterFirstUnlockkSecAttrAccessibleWhenUnlockeditems tokSecAttrAccessibleAfterFirstUnlock