Skip to content

Credentials forgotten when device is locked #306

@koke

Description

@koke

We haven't nailed the steps to reproduce yet, but it seems when the app is launched from a push notification, the items in the keychain are not accessible.

There are two things wrong with this scenario:

  • The app won't handle keychain errors and never tries to fetch credentials for the wp.com api again until next launch. See https://gist.github.com/koke/7238985 for a rough fix
  • We are storing passwords with the default kSecAttrAccessibleWhenUnlocked. It seems this is caused by duplication of the SFHFKeychainUtils wrapper: we have a modified one to use kSecAttrAccessibleAfterFirstUnlock, but the PocketAPI includes one, and there's a third one in Pods (not sure why).

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions