Skip to content

[Modal Layout Picker] Show toast messages after creating a new page#14886

Merged
chipsnyder merged 7 commits intodevelopfrom
gutenberg/issue/2453-toast
Oct 6, 2020
Merged

[Modal Layout Picker] Show toast messages after creating a new page#14886
chipsnyder merged 7 commits intodevelopfrom
gutenberg/issue/2453-toast

Conversation

@chipsnyder
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder commented Sep 11, 2020

Fixes wordpress-mobile/gutenberg-mobile#2453

Related PRs:
gutenberg-mobile wordpress-mobile/gutenberg-mobile#2613
gutenberg WordPress/gutenberg#25266

To test:

To disable or enable the development version of Modal Layout Picker
  • Open the app from the build that allows FeatureFlags such as a PR build or a local development build
    • By default, the modal layout picker will be disabled.
    • From the site page:
      • Click on your Gravatar.
      • Click on App Settings.
      • Click on Debug.
      • Toggle "Gutenberg Modal Layout Picker" to enable or disable the picker

When enabled, the Layout Picker should show when creating a new page from My Site and from the Page list.

Start by navigating to the Modal Layout Picker

Page Created (with content)

  1. Select a Layout from the options in Modal Layout Picker
  2. Select "Create Page"
    Expect to see the info notice banner appear under the navigation bar with the text "Page created"
  • 🗒️ This is different than the mocks in the linked issue but aligns with the direction that was determined.

Blank Page Created

  1. Select "Create Blank Page"
    Expect to see the info notice banner appear under the navigation bar with the text "Blank page created"
  • 🗒️ This is different than the mocks in the linked issue but aligns with the direction that was determined.

Blog Post Created

  1. Create a new blog post
  • This should not display the notice bar

Open existing Page Created

  1. Open an existing page (either published or draft)
  • This should not display the notice bar

Disable Modal Layout Picker

  1. Create a new page
  • This should not display the notice bar

Screenshots:

Create Page Create Blank Page Clip

Additional Context:

This is a continuation of the work done as part of the Modal Layout Picker Project and will be followed up by other tickets as part of Modal Layout Picker Project

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added this to the Someday milestone Sep 11, 2020
@chipsnyder chipsnyder requested a review from Tug September 11, 2020 20:55
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 11, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 11, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Copy Markdown
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chipsnyder chipsnyder modified the milestones: Someday, 16.0 Oct 2, 2020
@chipsnyder
Copy link
Copy Markdown
Contributor Author

The Gutenberg changes were merged after 1.38 was cut, so marking this as DO NOT MERGE until iOS 15.9 is cut to prevent a collision there.

@chipsnyder chipsnyder merged commit ca46c67 into develop Oct 6, 2020
@chipsnyder chipsnyder deleted the gutenberg/issue/2453-toast branch October 6, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants