[Modal Layout Picker] Show toast messages after creating a new page#14886
Merged
chipsnyder merged 7 commits intodevelopfrom Oct 6, 2020
Merged
[Modal Layout Picker] Show toast messages after creating a new page#14886chipsnyder merged 7 commits intodevelopfrom
chipsnyder merged 7 commits intodevelopfrom
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
This was referenced Sep 11, 2020
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
geriux
approved these changes
Oct 2, 2020
Contributor
geriux
left a comment
There was a problem hiding this comment.
Approved via wordpress-mobile/gutenberg-mobile#2613 (review) Nice work!
Contributor
Author
|
The Gutenberg changes were merged after 1.38 was cut, so marking this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#2453
Related PRs:
gutenberg-mobilewordpress-mobile/gutenberg-mobile#2613gutenbergWordPress/gutenberg#25266To test:
To disable or enable the development version of Modal Layout Picker
When enabled, the Layout Picker should show when creating a new page from My Site and from the Page list.
Start by navigating to the Modal Layout Picker
Page Created (with content)
Expect to see the info notice banner appear under the navigation bar with the text "Page created"
Blank Page Created
Expect to see the info notice banner appear under the navigation bar with the text "Blank page created"
Blog Post Created
Open existing Page Created
Disable Modal Layout Picker
Screenshots:
Additional Context:
This is a continuation of the work done as part of the Modal Layout Picker Project and will be followed up by other tickets as part of Modal Layout Picker Project
PR submission checklist:
RELEASE-NOTES.txtif necessary.