[Mobile] Create endpoint to post notices from host apps#25266
Merged
chipsnyder merged 3 commits intomasterfrom Oct 2, 2020
Merged
[Mobile] Create endpoint to post notices from host apps#25266chipsnyder merged 3 commits intomasterfrom
chipsnyder merged 3 commits intomasterfrom
Conversation
This was referenced Sep 11, 2020
|
Size Change: +70 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
Tug
reviewed
Sep 25, 2020
Contributor
Tug
left a comment
There was a problem hiding this comment.
Code LGTM, I have not product reviewed the whole PR chain.
Could you open an issue in gutenberg mobile to have feature parity for android related to this change?
Contributor
Author
For the Mobile Layout Picker work, we've just left a single issue open until both the iOS and Android side gets implemented. |
Contributor
Perfect then! |
geriux
approved these changes
Oct 2, 2020
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! Tested all cases on an iPhone 11 Pro Max and iPad 7.
Nice work @chipsnyder!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#2453
Related PRs:
gutenberg-mobilewordpress-mobile/gutenberg-mobile#2613WordPress-iOSwordpress-mobile/WordPress-iOS#14886Description
Adds an api that the host apps can use to present the info notice. This is being used as part of wordpress-mobile/gutenberg-mobile#2453 to show the page created messages.
🗒️ The linked PRs cover the iOS version of this feature. @antonis will be working on the Android side in a later PR.
How has this been tested?
🗒️ Test cases here are taken from wordpress-mobile/WordPress-iOS#14886
To disable or enable the development version of Modal Layout Picker
When enabled, the Layout Picker should show when creating a new page from My Site and from the Page list.
Start by navigating to the Modal Layout Picker
Page Created (with content)
Expect to see the info notice banner appear under the navigation bar with the text "Page created"
Blank Page Created
Expect to see the info notice banner appear under the navigation bar with the text "Blank page created"
Blog Post Created
Open existing Page Created
Disable Modal Layout Picker
Screenshots
Types of changes
Enhancement
Checklist: