Adds a welcome screen after the user sign ups or logs in with no sites added by emilylaguna · Pull Request #13523 · wordpress-mobile/WordPress-iOS

emilylaguna · 2020-02-20T20:01:49Z

Description

Adds a new displayed to users after login/signup if they have no sites added. The PSI screen will present them with the option of Creating a new site, adding a self-hosted site, or dismissing the screen.

The user will only see this screen once.

This branch includes fixes for following tickets:

Notes

Once this PR is approved the PR from WPiOS-Shared can be merged: Adds Post Sign Up Interstitial Tracks Events WordPress-iOS-Shared#249
Once merged, I'll change the WordPressShared section in the PodFile to the remove the specific branch and use the version instead

Video Demos

Login Flow

Device	Link
iPhone
iPad

Sign Up Flow

Device	Link
iPhone
iPad

Testing: Flows

Login with WP.com account with no sites

Part 1:

Launch the app
If you're logged in, log out
Tap Continue with WordPress.com
Login to an account that has no sites
Note: You should not be shown the login epilogue view:

Expectation: You should be displayed the interstitial view

Part 2:

Relaunch the app, you should not be displayed the interstitial

Part 3:

Log out and log back in

Expectation: You should not be displayed the interstitial view

Login with WP.com account with sites

Launch the app
If you're logged in, log out
Tap login
Tap Continue with WordPress.com

Expectation: You should be shown the login epilogue view

Login with self hosted site

Launch the app
If you're logged in, log out
Tap login
Tap 'entering your site address'
Enter a site address
Enter your username/password
Tap Next

Expectation: You should not be shown the interstitial, but you should see the login epilogue view

Sign Up Flow

Part 1:

Launch the app
If you're logged in, log out
Sign up for a new account
You should be shown the sign up epilogue view:

5. Tap continue

Expectation: You should be displayed the interstitial view

Part 2:

Log out and log back in

Expectation: You should not be displayed the interstitial view

Testing: Screen Actions

Note: In order to test each button option you will need to either:

Delete and relaunch the app after each button press since the PSI will not be displayed again for your account.

Login using a different account for each action

Create a site action

On the PSI screen
Tap Create a Site

Expectation: The PSI screen will be dismissed, and you will be brought to the Create a WP.com site:

Add self-hosted site action

On the PSI screen
Tap Add self-hosted site

Expectation: The PSI screen will be dismissed, and you will be brought to the add self hosted site flow:

Not right now action

On the PSI screen
Tap Not right now

Expectation: The PSI screen will be dismissed, and you will be brought reader tab

PR submission checklist:

I have considered adding unit tests where possible.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…-display-logic

…n or not

…i-screen Creates a new screen for the Post Sign Up Interstitial

…psi-display-logic

…isplay-logic Adds logic to determine when to show the post signup interstitial

…ides the dismiss action

…blogs

…a navigationController

pinarol · 2020-02-24T15:00:25Z

Hey there! I've moved this to 14.4 since 14.3 has been cut. If you want this to make it to 14.4, please feel free to ping me.

WordPress/Classes/Utility/Analytics/WPAnalyticsTrackerAutomatticTracks.m

yaelirub · 2020-02-25T00:46:30Z

I tested the flows and the work as expected though I found the description for the signup flow to be unclear.
I also found that during the transition to site creation from the interstitial, you can see "my site" in the background for a split second. Can we fix that?

Would still like a full review from @diegoreymendez . Please note, we are targeting 14.3.

yaelirub · 2020-02-25T00:53:25Z

...ess/Classes/ViewRelated/NUX/Post Signup Interstitial/PostSignUpInterstitialCoordinator.swift

+
+class PostSignUpInterstitialCoordinator {
+    private let database: KeyValueDatabase
+    private let userId: NSNumber?


Why is this an optional? Seems like the init method that takes the userid is only used for testing.
Will we have a situation where we wont have a userid?

Yes, if you sign in using a self hosted site there will not be a WP.com account for the user which results in the userID being nil.

diegoreymendez

The PR works fine for me. Nice job.

I think the only thing that feels a bit off is the transition briefly letting you see what's behind. I realize this isn't the easiest to fix but I believe it would be worth it to give it a shot.

Podfile

.../Classes/ViewRelated/NUX/Post Signup Interstitial/PostSignUpInterstitialViewController.swift

diegoreymendez

@emilylaguna - I've manually re-run the CircleCI tests since they failed.

On my end I still think it would be great to resolve the transition issue, but this PR is 👍

…and the other flows

emilylaguna · 2020-02-25T22:03:17Z

Alright, after much trial and error I unfortunately don't have a great solution for the transition issue. What I've done is set the dismiss animation flag to false which gives a quicker transition time. I have created an issue so I can tackle this again in the future: #13554

WordPress/Classes/ViewRelated/Blog/Blog List/BlogListViewController.m

...ess/Classes/ViewRelated/NUX/Post Signup Interstitial/PostSignUpInterstitialCoordinator.swift

Emily Laguna added 30 commits February 12, 2020 11:42

Add construct site illustration

862919a

Add Post Signup Interstitial screen

c10244c

Add temporary logic to display post signup interstitial (PSI)

18af4c9

Add temporary override to prevent the epilogue screens from displaying

203aa26

Add PSI notification handlers for create/add site actions

a4b4d93

Merge branch 'develop' into issue/12875-create-psi-screen

bc4e364

Merge branch 'issue/12875-create-psi-screen' into issue/12877-add-psi…

629ed60

…-display-logic

Add PSI screen localization

f8e4472

Disable PSI rotation on non-iPad devices

690be69

Merge branch 'issue/12875-create-psi-screen' into issue/12877-add-psi…

aab96c8

…-display-logic

Move the PSI notification observers to a new method

6fe3741

Add logic to the PSI ViewController to determine if it should be show…

fdc367d

…n or not

Update the BlogListViewController with the new PSI display logic

076cc7e

Remove debug logic for preventing the epilogue views from showing

fbd8a45

Reorganizes the PSI View Controller a bit

62cf88a

Merge pull request #13443 from wordpress-mobile/issue/12875-create-ps…

1b70d08

…i-screen Creates a new screen for the Post Sign Up Interstitial

Merge branch 'feature/post-signup-interstitial' into issue/12877-add-…

7e9c05f

…psi-display-logic

Remove TODO warnings that are no longer needed

51f4ca5

Improve Post Sign Up VC code quality

be211d2

Extract the PSI display logic to its own file

e23e88c

Add PSI test placeholder

02a5083

Improve testability of the PSI Coordinator

e170cd8

Add PSI Coordinator tests

bb5790a

Merge pull request #13459 from wordpress-mobile/issue/12877-add-psi-d…

41042ea

…isplay-logic Adds logic to determine when to show the post signup interstitial

Add logic to determine if we should show the login/signup epilogue views

6c1b3a4

Disable displaying of the PSI via the BlogListViewController

cfd2d2f

Add onContinue closure to the SignupEpilogueViewController that overr…

317a224

…ides the dismiss action

Update the PSI View Controller automatically determine the number of …

2b6baa7

…blogs

Update the PSI ViewController support an onDismiss closure and using …

52927ba

…a navigationController

Add PSI displaying logic to the WordPressAuthenticationManager

28b1eea

pinarol modified the milestones: 14.3 ❄️, 14.4 Feb 24, 2020

emilylaguna changed the base branch from develop to release/14.3 February 24, 2020 21:53

Merge branch 'release/14.3' into feature/post-signup-interstitial

44236c3

emilylaguna modified the milestones: 14.4, 14.3 ❄️ Feb 24, 2020

emilylaguna requested review from yaelirub and removed request for diegoreymendez February 24, 2020 22:15

yaelirub reviewed Feb 24, 2020

View reviewed changes

WordPress/Classes/Utility/Analytics/WPAnalyticsTrackerAutomatticTracks.m Show resolved Hide resolved

yaelirub requested review from diegoreymendez and yaelirub February 25, 2020 00:45

yaelirub reviewed Feb 25, 2020

View reviewed changes

diegoreymendez reviewed Feb 25, 2020

View reviewed changes

Podfile Outdated Show resolved Hide resolved

.../Classes/ViewRelated/NUX/Post Signup Interstitial/PostSignUpInterstitialViewController.swift Outdated Show resolved Hide resolved

Move the coordinator reference to viewDidLoad

fcb932b

diegoreymendez approved these changes Feb 25, 2020

View reviewed changes

Disables the dismiss animation to improve the transition between PSI …

0aedcae

…and the other flows

jleandroperez reviewed Feb 26, 2020

View reviewed changes

WordPress/Classes/ViewRelated/Blog/Blog List/BlogListViewController.m Outdated Show resolved Hide resolved

jleandroperez reviewed Feb 26, 2020

View reviewed changes

...ess/Classes/ViewRelated/NUX/Post Signup Interstitial/PostSignUpInterstitialCoordinator.swift Outdated Show resolved Hide resolved

Emily Laguna added 4 commits February 26, 2020 07:33

Remove unnecessary return

e086c53

Remove direct strings for notifications in ObjC

d91f165

Update the WordPressShared pod version to 1.8.14

582b724

Update PodFile.lock

19ca69c

emilylaguna merged commit 50bb4d9 into release/14.3 Feb 26, 2020

emilylaguna deleted the feature/post-signup-interstitial branch February 26, 2020 17:11

jkmassel restored the feature/post-signup-interstitial branch February 27, 2020 17:32

rachelmcr mentioned this pull request Mar 17, 2020

Display interstitial after login if no sites #12916

Closed

emilylaguna deleted the feature/post-signup-interstitial branch April 7, 2020 21:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds a welcome screen after the user sign ups or logs in with no sites added#13523

Adds a welcome screen after the user sign ups or logs in with no sites added#13523
emilylaguna merged 44 commits intorelease/14.3from
feature/post-signup-interstitial

emilylaguna commented Feb 20, 2020 •

edited

Loading

Uh oh!

pinarol commented Feb 24, 2020

Uh oh!

Uh oh!

yaelirub commented Feb 25, 2020 •

edited

Loading

Uh oh!

yaelirub Feb 25, 2020

Uh oh!

emilylaguna Feb 25, 2020

Uh oh!

diegoreymendez left a comment

Uh oh!

Uh oh!

Uh oh!

diegoreymendez left a comment

Uh oh!

emilylaguna commented Feb 25, 2020

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

emilylaguna commented Feb 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes

Video Demos

Login Flow

Sign Up Flow

Testing: Flows

Login with WP.com account with no sites

Login with WP.com account with sites

Login with self hosted site

Sign Up Flow

Testing: Screen Actions

Uh oh!

pinarol commented Feb 24, 2020

Uh oh!

Uh oh!

yaelirub commented Feb 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yaelirub Feb 25, 2020

Choose a reason for hiding this comment

Uh oh!

emilylaguna Feb 25, 2020

Choose a reason for hiding this comment

Uh oh!

diegoreymendez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

diegoreymendez left a comment

Choose a reason for hiding this comment

Uh oh!

emilylaguna commented Feb 25, 2020

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

emilylaguna commented Feb 20, 2020 •

edited

Loading

yaelirub commented Feb 25, 2020 •

edited

Loading