Adds logic to determine when to show the post signup interstitial#13459
Merged
emilylaguna merged 17 commits intofeature/post-signup-interstitialfrom Feb 14, 2020
Merged
Conversation
added 11 commits
February 12, 2020 11:45
…psi-display-logic
|
You can trigger an installable build for these changes by visiting CircleCI here. |
leandroalonso
requested changes
Feb 14, 2020
Contributor
leandroalonso
left a comment
There was a problem hiding this comment.
@emilylaguna tested and it works as expected!
I left a few comments, let me know what you think.
.../Classes/ViewRelated/NUX/Post Signup Interstitial/PostSignUpInterstitialViewController.swift
Outdated
Show resolved
Hide resolved
.../Classes/ViewRelated/NUX/Post Signup Interstitial/PostSignUpInterstitialViewController.swift
Outdated
Show resolved
Hide resolved
.../Classes/ViewRelated/NUX/Post Signup Interstitial/PostSignUpInterstitialViewController.swift
Outdated
Show resolved
Hide resolved
added 6 commits
February 14, 2020 07:36
leandroalonso
approved these changes
Feb 14, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12877 and #12916
To test:
3.a Sign up for a new account
PR submission checklist:
RELEASE-NOTES.txtif necessary.