Merged
Conversation
Generated by 🚫 dangerJS |
This was referenced Jan 21, 2020
pinarol
reviewed
Jan 21, 2020
Podfile
Outdated
| ## ===================== | ||
| ## | ||
| gutenberg :commit => 'aaa43ff63c6fc8dd44f6bd45af25e2f91619d6a5' | ||
| gutenberg :commit => '2bf7408427195ce361675a6bfb48d7ed07da22e3' |
Contributor
There was a problem hiding this comment.
Let's not forget this to update this as before merging
gutenberg :tag => 'hotfix/v1.20.1'
Contributor
Author
There was a problem hiding this comment.
Thanks for the reminder. Updated as :tag => 'v1.20.1'.
pinarol
approved these changes
Jan 21, 2020
Contributor
pinarol
left a comment
There was a problem hiding this comment.
LGTM! Tested with the ipa link in this PR, verified that the image size option isn't showing:
Thank you for the fix Matthew!
Contributor
Author
|
Thanks for testing @pinarol 😃 I tested one more time after the reference update with the generated ipa here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#1792
This PR updates the
gutenberg-mobilereference to point tov1.20.1, a hotfix release.Note: First it the Podfile will reference a commit hash to run CI tests, then after all PRs are green, the Podfile will be updated to reference a tag (after the hotfix is merged to gutenberg-mobile master, and tagged there).
Related PRs:
gutenberg: WordPress/gutenberg#19774gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1794WordPress-Android: wordpress-mobile/WordPress-Android#11120Description
This PR disables the gallery image size options on mobile. We can re-enable them after we've verified / implemented the desired behavior for mobile.
To test:
Steps:
Expected result:
The image size option should not be visible in the menu.
PR submission checklist:
RELEASE-NOTES.txtif necessary.