[Mobile] Disable gallery size options on mobile#19774
Merged
mkevins merged 1 commit intornmobile/release-v1.20.1from Jan 22, 2020
Merged
[Mobile] Disable gallery size options on mobile#19774mkevins merged 1 commit intornmobile/release-v1.20.1from
mkevins merged 1 commit intornmobile/release-v1.20.1from
Conversation
This was referenced Jan 21, 2020
pinarol
approved these changes
Jan 21, 2020
Contributor
pinarol
left a comment
There was a problem hiding this comment.
LGTM! Tested with the direct app links in the main app PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
This PR can be merged into the
v1.20.1branch. Thev1.20.1branch does not need to be merged. Its purpose is for the v1.20.1 hotfix only, and that branch can be deleted. The release tag should be created from this branch, since this repository does not allow merge commits (so we will not get a clean fast-forward). Forv1.21.0, simply omitting this PR will leave the options enabled, but a small fix is needed to show labels correctly, and this should be tested and get some design approval (the reason for not including this in the hotfix).Related PRs:
gutenberg-mobile(hotfix): wordpress-mobile/gutenberg-mobile#1794WordPress-Android: wordpress-mobile/WordPress-Android#11120WordPress-iOS: wordpress-mobile/WordPress-iOS#13252Description
This PR disables the gallery image size options on mobile. We can re-enable them after we've verified / implemented the desired behavior for mobile.
How has this been tested?
Tested on iOS via WordPress-iOS.
Steps:
Expected result:
The image size option should not be visible in the menu.
Screenshots
Types of changes
This uses the
Platform.selectfunction to provide an empty array of image size options on mobile, leaving web implementation unchanged. There is already logic in place to hide the option when the array is empty, so this is sufficient to hide the option on mobile.Checklist: