Skip to content

Disable gallery size options#11120

Merged
mkevins merged 2 commits intorelease/14.0from
fix/disable-gallery-size-options
Jan 22, 2020
Merged

Disable gallery size options#11120
mkevins merged 2 commits intorelease/14.0from
fix/disable-gallery-size-options

Conversation

@mkevins
Copy link
Copy Markdown
Contributor

@mkevins mkevins commented Jan 21, 2020 •
edited
Loading

Fixes wordpress-mobile/gutenberg-mobile#1792

This PR updates the gutenberg-mobile reference to point to v1.20.1, a hotfix release.

Related PRs:

gutenberg: WordPress/gutenberg#19774
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1794
WordPress-iOS: wordpress-mobile/WordPress-iOS#13252

Description

This PR disables the gallery image size options on mobile. We can re-enable them after we've verified / implemented the desired behavior for mobile.

To test:

Steps:

  • Create a gallery block with some images
  • Tap the gallery
  • Tap the gallery settings icon (the gear)

Expected result:

The image size option should not be visible in the menu.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mkevins mkevins added Gutenberg Editing and display of Gutenberg blocks. gutenberg-mobile labels Jan 21, 2020
@mkevins mkevins mentioned this pull request Jan 21, 2020
Merged
2 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 21, 2020

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@mkevins mkevins mentioned this pull request Jan 21, 2020
Merged
6 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 21, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@mkevins mkevins mentioned this pull request Jan 21, 2020
Merged
2 tasks
pinarol
pinarol approved these changes Jan 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with the apk link in this PR, verified that the image size option isn't showing:

Screenshot_20200121_202822_org wordpress android

@mkevins mkevins merged commit f77478b into release/14.0 Jan 22, 2020
@mkevins mkevins deleted the fix/disable-gallery-size-options branch January 22, 2020 06:14
@mkevins
Copy link
Copy Markdown
Contributor Author

mkevins commented Jan 22, 2020 •
edited
Loading

Thanks for testing @pinarol 😃

I tested one more time after the reference update with the generated apk here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinarol pinarol pinarol approved these changes

Assignees

No one assigned

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkevins @pinarol