[VoiceOver] Add accessibility to Post List buttons#13057
Merged
shiki merged 1 commit intowordpress-mobile:developfrom Dec 11, 2019
Merged
[VoiceOver] Add accessibility to Post List buttons#13057shiki merged 1 commit intowordpress-mobile:developfrom
shiki merged 1 commit intowordpress-mobile:developfrom
Conversation
Contributor
|
Hi @vphong! No worries. It looks like there are some unrelated commits in this PR:
Would you mind removing those first? You'd probably need to |
b4d8d61 to
b15eff0
Compare
Contributor
Author
|
@shiki Sorry about that, taken care of now with some interactive rebasing. |
shiki
reviewed
Dec 10, 2019
WordPress/Classes/ViewRelated/Post/PostListViewController.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Post/PostListViewController.swift
Outdated
Show resolved
Hide resolved
Specifically, added to `addButton` and `postViewButtonItem`.
This was referenced Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12872, Fixes #12870 with issues addressed in #13038. I apologize @shiki, I was having issues building and didn't realize deleting the remote branch would close the other pull request. The issues you brought up have been taken care of, though!
To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.