I think a better place for this would be the addButton's initializer in here:

In this way, we can also fix the same problem in the Pages List.

The label can also just be “Add”. There is enough context on the page that the user should be able to figure out that “Add” means adding a new post or adding a new page. You can read more about this in the Guidelines for creating labels.

Lastly, strings should be localized. Using NSLocalizedString should be enough. The translation will be handled during the release process. Please feel free to poke around in the codebase for some examples. 🙂

• Move to the addButton initializer
• Use NSLocalizedString
• Shorten to "Add"

It looks like you only need to do this once in showCompactOrDefault() which is called on viewDidLoad and whenever isCompact value is changed. The less code, the better. What do you think? 🙂

As for the accessibilityLabel, this is a bit tricky because it's a toggle button. Changing the label can be confusing though. The user might think that it's a different button whenever it changes. My suggestion would be to have a static accessibilityLabel, “List style”, so the user will be able to identify that it's the same button. And then change the accessibilityValue.

The label and the values will still be spoken by VoiceOver.

• Move to showCompactOrDefault()
• Use accessibilityValue

I did write that line twice, because I thought it was possible that the user might have left the app on a certain compact or expanded view, and they might want to return to their choice of view. So it calculates once on viewDidLoad and when the toggle is hit. Is this not necessary? Edit: alright I understand showCompactOrDefault() now, my bad! Will get to it

I'll work on the other changes as well!