Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Merge Woo sign in with self hosted credentials changes#30

Merged
AmandaRiu merged 47 commits intodevelopfrom
merge-wc-login-changes
Nov 22, 2019
Merged

Merge Woo sign in with self hosted credentials changes#30
AmandaRiu merged 47 commits intodevelopfrom
merge-wc-login-changes

Conversation

@anitaa1990
Copy link
Copy Markdown
Contributor

This PR merges the woocommerce-android changes to the login library from this PR - which includes detailed documentation on what changed in the Woo login flow, including screenshots.

There were a handful of new interface methods and strings added to the login lib that would need to be incorporated to the WPAndroid project. I've opened a draft PR on WordPress-Android that merges the changes from this branch, as well as implements the interface methods so WPAndroid can be fully tested before this branch is merged, and includes recommended testing scenarios.

AmandaRiu and others added 30 commits July 12, 2019 16:28
…Android/24

Merge recent WordPress-Login-Flow-Android changes
…gin-lib

# Conflicts:
#	libs/login/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginSiteAddressFragment.java
Merge in latest changes from login library
This applies only to non-atomic stores. Due to some bugs in the
connected site info endpoint the other properties are not currently
reporting properly and this is causing the check for jetpack to fail
during the login process. All we need to know is if it's connected so
I've verified this field will work for our uses.
@AmandaRiu AmandaRiu self-assigned this Nov 22, 2019
Copy link
Copy Markdown
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this PR have been tested for WPAndroid and WCAndroid successfully. Merging. :shipit:

@AmandaRiu AmandaRiu merged commit f58a4c8 into develop Nov 22, 2019
@AmandaRiu AmandaRiu deleted the merge-wc-login-changes branch November 22, 2019 19:22
wzieba pushed a commit that referenced this pull request Oct 15, 2024
Merge Woo sign in with self hosted credentials changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants