This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Merge Woo sign in with self hosted credentials changes#30
Merged
Merge Woo sign in with self hosted credentials changes#30
Conversation
…Android/24 Merge recent WordPress-Login-Flow-Android changes
Merge Release/2.3 into develop
…gin-lib # Conflicts: # libs/login/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginSiteAddressFragment.java
Merge in latest changes from login library
This applies only to non-atomic stores. Due to some bugs in the connected site info endpoint the other properties are not currently reporting properly and this is causing the check for jetpack to fail during the login process. All we need to know is if it's connected so I've verified this field will work for our uses.
…46-login-lib-merge
…essage when site is not found
…irect to magic link screen
…f the xmlrpc url is empty
…if site is wp.com
…e/1482-step2-magic-link-signin-changes
…os from the calling fragment
… utilise LoginBaseDiscoveryFragment
…ors since it can return a false negative
…-mobile/WordPress-Login-Flow-Android into merge-wc-login-changes
AmandaRiu
approved these changes
Nov 22, 2019
Contributor
AmandaRiu
left a comment
There was a problem hiding this comment.
Changes in this PR have been tested for WPAndroid and WCAndroid successfully. Merging. ![]()
wzieba
pushed a commit
that referenced
this pull request
Oct 15, 2024
Merge Woo sign in with self hosted credentials changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the woocommerce-android changes to the login library from this PR - which includes detailed documentation on what changed in the Woo login flow, including screenshots.
There were a handful of new interface methods and strings added to the login lib that would need to be incorporated to the WPAndroid project. I've opened a draft PR on WordPress-Android that merges the changes from this branch, as well as implements the interface methods so WPAndroid can be fully tested before this branch is merged, and includes recommended testing scenarios.