Fixes #1482. This is the master branch for the sign in with self hosted credentials feature.

Screenshots

Site credentials login - with Jetpack

Site credentials login - without Jetpack

(LEFT: Try Login without jetpack . RIGHT: Activate Jetpack while on the app and click onTRY AGAIN)
.

Discovery errors:

Logging into a site with HTTP AUTH required when Jetpack is NOT available:

(LEFT: When jetpack is still not installed and user clicks on Try AGAIN button)
(RIGHT: When jetpack is installed when user is on the screen and clicks on TRY AGAIN button)
.

Logging into a site with XMLRPC missing when Jetpack is available:

Logging into a site with missing rsd tags:

Logging into a site with SSL Certificate error :

Logging into a site with the XML-RPC request is blocked :

Different discovery error messages:

(LEFT: HTTP AUTH required . RIGHT: SSL certificate needed)
.

(LEFT: XMLRPC errors . RIGHT: All other generic errors)
.

Testing

Test Current Functionality

• Basic login - with Jetpack and Woo
• Basic login - without Jetpack
• Basic login - without Woo
• Basic login - site does not belong to WPcom account

Test New Functionality

• Site credentials login - with Jetpack and Woo using magic link flow
• Site credentials login - with Jetpack and Woo using enter password flow
• Site credentials login - without Jetpack
  • Enable jetpack from last step and refresh - should get redirected to the site credentials screen.
• Site creds login - without Woo
• Site creds login - site with multiple jetpacked accounts

Other Testing

• Log in to a non-existent site
• Log in with a non-WP site
• Enter a jetpack site and verify directed to the magic link screen
• Enter a bad password for site creds
• Enter an invalid username for site creds

Discovery error scenarios

Scenario I: Login to a site with XMLRPC file renamed.

• Login to anitaamurthy.com in wp-admin.
• Install, activate and connect Jetpack.
• Open the app and enter the above site address and click on Next.
• Verify that you are redirected to the Sign in with Jetpack screen (even though Jetpack is installed on the site). This is because the XMLRPC file is renamed for this site and cannot be found so even if Jetpack is available, the API response returns false for the fields hasJetpack: true, isJetpackActive: false, isJetpackConnected: false.
• Click on Sign in in the app.
• Click on Login with site credentials and enter username + password.
• Verify that you are redirected to the discovery error screen and the error message displayed is We were unable to access the XMLRPC file on your site. You will need to reach out to your host to resolve this..
• Verify that clicking on Try again redirects to the Username + password screen.
• Verify that clicking on Read our troubleshooting tips redirects to a webview from this link.
• Verify that clicking on Help opens the help page.
• Verify that clicking in Sign in with Wordpress.com redirects to the Email screen and you are able to login successfully to the app using wp.com email.

Scenario II: Login to a site with SSL Certificate required error:

(This scenario is the same as the above scenario but with different discovery error type: ERRONEOUS_SSL_CERTIFICATE)

• Login to anitaastestwpsite2.com in wp-admin.
• Install, activate and connect Jetpack.
• Open the app and enter the above site address and click on Next.
• Click on Login with site credentials and enter username + password.
• Verify that you are redirected to the discovery error screen and the error message displayed is We were unable to access your site because of a problem with the SSL Certificate. You will need to reach out to your host to resolve this..
• Verify that clicking on Try again redirects to the Username + password screen.
• Verify that clicking on Read our troubleshooting tips redirects to a webview from this link.
• Verify that clicking on Help opens the help page.
• Verify that clicking in Sign in with Wordpress.com redirects to the Email screen and you are able to login successfully to the app using wp.com email.

Login to a site with HTTP AUTH required error

• Login to any test site in wp-admin.
• Uninstall Jetpack from the Plugins section.
• Activate HTTP Auth plugin from the same page. This enables HTTP Auth to the site.
• Open the app and enter the above site address and click on Next.
• Verify that you are redirected to the Sign in with Jetpack screen (since Jetpack is not active on the site).
• Click on Sign in in the app.
• Click on Login with site credentials and enter username + password.
• Verify you are redirected to the Jetpack required screen.
• Click on Try again.
• Verify that an error snackbar is displayed stating that Jetpack is not active on the site.
• Go back to the Plugins page in wp-admin and deactivate HTTP Auth before activating and connecting Jetpack (This is because Jetpack does not support HTTP Auth plugin and you will only be able to connect Jetpack if HTTP Auth plugin is deactivated).
• Go back to the app and click on Try again.
• Verify that you are redirected back to the site credentials screen.
• Click on Next and verify that you are successfully redirected to the Magic link screen.

Login to a site with XMLRPC is blocked.

• Login to any test site in wp-admin.
• Install the plugin Disable XML-RPC.
• Open the app and enter the above site address and click on Next.
• If Jetpack is not active on the site, verify that:
  • You are redirected to the Sign in with Jetpack screen.
  • Click on Sign in in the app.
  • Click on Login with site credentials and enter username + password.
• If Jetpack is active on the site, verify that:
  • You are redirected to the username password screen.
  • Click on Login with site credentials and enter username + password.
• In either case, verify that you are redirected to the discovery error screen and the error message displayed is We were unable to access the XMLRPC file on your site. You will need to reach out to your host to resolve this..

Notes:

• All events added in this PR have already been validated/registered.
• Once this PR is approved, I will open another PR in the login lib and the WP-android repo to merge these changes as suggested here.

Update release notes:

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.