Skip to content

Issue/1482 step4 track events#1518

Merged
AmandaRiu merged 12 commits intofeature/sign-in-with-self-hosted-credentialsfrom
issue/1482-step4-track-events
Nov 7, 2019
Merged

Issue/1482 step4 track events#1518
AmandaRiu merged 12 commits intofeature/sign-in-with-self-hosted-credentialsfrom
issue/1482-step4-track-events

Conversation

@anitaa1990
Copy link
Copy Markdown
Contributor

@anitaa1990 anitaa1990 commented Nov 1, 2019

Partially fixes #1482. This PR completes the fourth step of the Jetpack sign in with self credentials as defined in the master thread here. This PR adds new tracking events added as part of this feature.

Events

  • LOGIN_NO_JETPACK_SCREEN_VIEWED - The no jetpack available screen is loaded.
  • LOGIN_NO_JETPACK_VIEW_INSTRUCTIONS_BUTTON_TAPPED - User tapped on the "View Instructions" button on the no jetpack available screen.
  • LOGIN_NO_JETPACK_LOGOUT_LINK_TAPPED - User tapped on the "Logout" link on the no jetpack available screen.
  • LOGIN_NO_JETPACK_TRY_AGAIN_TAPPED - User tapped on the "Try again" button on the no jetpack available screen.
  • LOGIN_NO_JETPACK_MENU_HELP_TAPPED - User tapped on the Help menu button on the no jetpack available screen.
  • LOGIN_DISCOVERY_ERROR_SCREEN_VIEWED - The discovery error screen is loaded.
  • LOGIN_DISCOVERY_ERROR_TROUBLESHOOT_BUTTON_TAPPED - User tapped on the "Read our troubleshooting tips" button on the discovery error screen.
  • LOGIN_DISCOVERY_ERROR_TRY_AGAIN_TAPPED - User tapped on the "Try again" button on the discovery error screen.
  • LOGIN_DISCOVERY_ERROR_SIGN_IN_WORDPRESS_BUTTON_TAPPED - User tapped on the "Sign in with wordpress" button on the discovery error screen.
  • LOGIN_DISCOVERY_ERROR_MENU_HELP_TAPPED - User tapped on the Help menu button on the on the discovery error screen.
  • LOGIN_MAGIC_LINK_INTERCEPT_SCREEN_VIEWED - The magic link intercept screen is viewed. This is the view that is displayed when the user clicks on a magic link from their device.
  • LOGIN_MAGIC_LINK_INTERCEPT_RETRY_TAPPED - User tapped on the "Retry" button on the magic link intercept screen. This button is only displayed when the user account, user account settings or the site list could not be fetched.
  • LOGIN_MAGIC_LINK_UPDATE_TOKEN_FAILED - The request submitted to update the magic link token to the FluxC cache has failed.
  • LOGIN_MAGIC_LINK_FETCH_ACCOUNT_FAILED - The request submitted to fetch user account info from the API has failed.
  • LOGIN_MAGIC_LINK_FETCH_ACCOUNT_SETTINGS_FAILED - The request submitted to fetch user account settings from the API has failed.
  • LOGIN_MAGIC_LINK_FETCH_SITES_FAILED - The request submitted to fetch sites belonging to the user account from the API has failed.
  • LOGIN_MAGIC_LINK_FETCH_ACCOUNT_SUCCESS - The request submitted to fetch user account info from the API was successful.
  • LOGIN_MAGIC_LINK_FETCH_ACCOUNT_SETTINGS_SUCCESS - The request submitted to fetch user account settings from the API was successful.
  • LOGIN_MAGIC_LINK_FETCH_SITES_SUCCESS - The request submitted to fetch sites belonging to the user account from the API was successful.

Notes:

- This PR is in draft till this Step 3 PR is merged.

TODO

  • Add tracks events to the spreadsheet
  • Validate and register the new tracks events

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@anitaa1990 anitaa1990 added Login category: tracks Related to analytics, including Tracks Events. labels Nov 1, 2019
@anitaa1990 anitaa1990 added this to the 3.0 milestone Nov 1, 2019

val trackEvent = when {
event.causeOfChange == AccountAction.FETCH_ACCOUNT -> Stat.LOGIN_MAGIC_LINK_FETCH_ACCOUNT_FAILED
event.causeOfChange == AccountAction.FETCH_ACCOUNT -> Stat.LOGIN_MAGIC_LINK_FETCH_ACCOUNT_SETTINGS_FAILED
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter: Checkstyle
Rule: max-line-length
Severity: ERROR
File: /home/circleci/project/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/login/MagicLinkInterceptRepository.kt L218
Exceeded max line length (120) (cannot be auto-corrected)

@peril-woocommerce
Copy link
Copy Markdown

peril-woocommerce bot commented Nov 1, 2019

You can test the changes on this Pull Request by downloading the APK here.

@anitaa1990 anitaa1990 added Login and removed Login labels Nov 1, 2019
@JavonDavis
Copy link
Copy Markdown
Contributor

Hey! Bumping this to 3.1, if you'd like to get it in for this release please merge this into release/3.0 and then DM me to release a new Beta version.

@JavonDavis JavonDavis modified the milestones: 3.0, 3.1 Nov 6, 2019
@anitaa1990 anitaa1990 marked this pull request as ready for review November 6, 2019 09:46
@peril-woocommerce
Copy link
Copy Markdown

Messages
📖

This PR contains changes to Tracks-related logic. Please ensure the following are completed:
PR Author

  • The PR must be assigned the Tracks label
    PR Reviewer
  • The tracks events must be validated in the Tracks system.
  • Verify the internal tracks spreadsheet has also been updated.

Generated by 🚫 dangerJS

@AmandaRiu AmandaRiu self-assigned this Nov 7, 2019
Copy link
Copy Markdown
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @anitaa1990! I left a couple small comments in code for your review.

@anitaa1990
Copy link
Copy Markdown
Contributor Author

Thanks for the review @AmandaRiu! I've addressed all the issues and PR is ready for another round 👍

@anitaa1990 anitaa1990 requested a review from AmandaRiu November 7, 2019 18:34
Copy link
Copy Markdown
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 :shipit:

@AmandaRiu AmandaRiu merged commit 9cf43f4 into feature/sign-in-with-self-hosted-credentials Nov 7, 2019
@AmandaRiu AmandaRiu deleted the issue/1482-step4-track-events branch November 7, 2019 19:01
@designsimply designsimply added feature: login Related to any part of the log in or sign in flow, or authentication. and removed Login labels May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tracks Related to analytics, including Tracks Events. feature: login Related to any part of the log in or sign in flow, or authentication.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants