This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Fix tracks connected info property naming#26
Merged
malinajirka merged 4 commits intodevelopfrom Aug 7, 2019
Merged
Conversation
added 3 commits
August 1, 2019 16:29
# Conflicts: # WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginSiteAddressFragment.java
Contributor
|
Thanks @AmandaRiu! The changes look good. My only concerns is if it's a good idea to rename the properties. In general changing names of events or properties isn't a good idea as it will break already existing funnels/queries. This is especially true when the events are related to login/signup/sitecreation as we have some cross-platform funnels which we regularly check. I'm not saying we shouldn't make this change, I just wanted to raise this point. I want to be 100% this change is safe to do. Wdyt? |
Contributor
|
ok, just ignore my comment:D. I forgot you actually checked the previous properties were being completely ignored. I'll double check the subtree and merge this PR ;). |
Contributor
Author
|
thanks @malinajirka !! 💃 |
wzieba
pushed a commit
that referenced
this pull request
Oct 15, 2024
…d/1287 Fix tracks connected info property naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the changes defined in this WCAndroid PR. The changes are minor, I just needed to fix the property names of the
_login_connected_site_info_succeededevent so the properties would get properly saved to the event.This Draft PR can be used for testing these changes in WPAndroid.