Skip to content

Fix tracks connected info property naming#1287

Merged
nbradbury merged 1 commit intorelease/2.2.1from
issue/1284-fix-login-tracks
Jul 26, 2019
Merged

Fix tracks connected info property naming#1287
nbradbury merged 1 commit intorelease/2.2.1from
issue/1284-fix-login-tracks

Conversation

@AmandaRiu
Copy link
Copy Markdown
Contributor

Fixes #1284 by renaming the event properties for LOGIN_CONNECTED_SITE_INFO_SUCCEEDED to conform to the tracks property naming convention. Also added a new property called login_calculated_has_jetpack to make it easier to report on whether or not jetpack is active and connected since determining that requires looking at several properties.

Logcat event:

Tracked: login_connected_site_info_succeeded, Properties: {"is_wp_com":"false","has_jetpack":"true","is_wordpress":"true","login_calculated_has_jetpack":"true","is_jetpack_active":"true","url_after_redirects":"http:\/\/testwooshop.mystagingwebsite.com","exists":"true","is_jetpack_connected":"true","url":"testwooshop.mystagingwebsite.com"}

I already verified in Tracks the new events are properly being saved, so the reviewer need only approve and merge :)

Screen Shot 2019-07-26 at 11 08 27 AM

This fix has been built off of the 2.2 release tag in the hopes that we can get it released as a hotfix.

cc: @jkmassel @loremattei

@AmandaRiu AmandaRiu added the category: tracks Related to analytics, including Tracks Events. label Jul 26, 2019
@AmandaRiu AmandaRiu added this to the 2.2 milestone Jul 26, 2019
@peril-woocommerce
Copy link
Copy Markdown

Messages
📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into WordPress-Login-Flow-Android. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd woocommerce-android
  2. git checkout issue/1284-fix-login-tracks
  3. git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/woocommerce-android/1287
  4. Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/woocommerce-android/1287 and open a new PR.

Generated by 🚫 dangerJS

@AmandaRiu AmandaRiu requested a review from nbradbury July 26, 2019 17:09
@nbradbury nbradbury self-assigned this Jul 26, 2019
@nbradbury
Copy link
Copy Markdown
Contributor

:shipit:

@nbradbury nbradbury merged commit 441953a into release/2.2.1 Jul 26, 2019
@nbradbury nbradbury deleted the issue/1284-fix-login-tracks branch July 26, 2019 17:46
@AmandaRiu AmandaRiu modified the milestones: 2.2, 2.4 ❄️ Jul 29, 2019
@AmandaRiu AmandaRiu restored the issue/1284-fix-login-tracks branch August 1, 2019 20:57
@AmandaRiu AmandaRiu deleted the issue/1284-fix-login-tracks branch October 18, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tracks Related to analytics, including Tracks Events.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants