Fix tracks connected info property naming#1287
Merged
nbradbury merged 1 commit intorelease/2.2.1from Jul 26, 2019
Merged
Conversation
Generated by 🚫 dangerJS |
nbradbury
reviewed
Jul 26, 2019
...n/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginSiteAddressFragment.java
Show resolved
Hide resolved
Contributor
|
|
1 task
This was referenced Aug 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1284 by renaming the event properties for
LOGIN_CONNECTED_SITE_INFO_SUCCEEDEDto conform to the tracks property naming convention. Also added a new property calledlogin_calculated_has_jetpackto make it easier to report on whether or not jetpack is active and connected since determining that requires looking at several properties.Logcat event:
I already verified in Tracks the new events are properly being saved, so the reviewer need only approve and merge :)
This fix has been built off of the
2.2release tag in the hopes that we can get it released as a hotfix.cc: @jkmassel @loremattei