This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Merge latest changes from WordPress-Android#24
Merged
Conversation
…en a start/end attribute already exists
…-wp-2 Merge login lib changes and implement new interface methods
This time, the _Next_ button is not enabled until the user has entered an invalid site address.
The invalid address error message will only be shown 2 seconds after the user stopped typing.
This is to match the new iOS error message.
This is based on Editorial’s advice.
…20-login-subtree-update # Conflicts: # libs/login/WordPressLoginFlow/build.gradle # libs/login/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginSiteAddressFragment.java # libs/login/WordPressLoginFlow/src/main/res/layout-land/login_magic_link_request_screen.xml # libs/login/WordPressLoginFlow/src/main/res/layout-land/login_magic_link_sent_screen.xml # libs/login/WordPressLoginFlow/src/main/res/layout-land/signup_bottom_sheet_dialog.xml # libs/login/WordPressLoginFlow/src/main/res/layout-land/signup_magic_link.xml # libs/login/WordPressLoginFlow/src/main/res/layout/login_email_password_screen.xml # libs/login/WordPressLoginFlow/src/main/res/layout/login_email_screen.xml # libs/login/WordPressLoginFlow/src/main/res/layout/login_form_screen.xml # libs/login/WordPressLoginFlow/src/main/res/layout/login_input_row.xml # libs/login/WordPressLoginFlow/src/main/res/layout/login_magic_link_request_screen.xml # libs/login/WordPressLoginFlow/src/main/res/layout/login_username_password_screen.xml # libs/login/WordPressLoginFlow/src/main/res/values/strings.xml
…en a start/end attribute already exists
This was referenced Jul 22, 2019
This was referenced Jul 22, 2019
1 task
wzieba
pushed a commit
that referenced
this pull request
Oct 15, 2024
…10255 Merge latest changes from WordPress-Android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains the changes from:
Testing
I'm not quite sure how testing should be done for this type of PR. I have created draft pull requests using this branch:
I have tested both WC and WP and did not see any issues.
Reviewing
Only 1 reviewer is needed but anyone can review.
Tasks