Merged
Conversation
Generated by 🚫 dangerJS |
…en a start/end attribute already exists
5a61c0a to
36a5b41
Compare
planarvoid
approved these changes
Jul 4, 2019
Contributor
planarvoid
left a comment
There was a problem hiding this comment.
Everything looks good, works as expected 👍
This was referenced Jul 22, 2019
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration documentation
I checked the migration and the what changed in Android 9 documentation. A few things that must done in wpandroid:
Done in ad8be63
Done in 72fb4f5
Got a crash in the Login screen due to an outdated Lottie version
Stumbled on an error from Lottie.
I updated the dependency to the latest version in 57f8f4d.
Lint error:
Using left/right instead of start/end attributesI had to bump minimum sdk version for the login flow from 16 to 17 (API <= 16 requires left/right attributes and start/end, which is incompatible with the changes in API 28).
Done in 5a61c0a764
Bumped to latest FluxC version in 56e200c
Note: only one line changed in FluxC between current and updated versions
Tests