Feature/2886 general site settings#2979
Merged
nbradbury merged 69 commits intofeature/site-settings-reviewfrom Aug 26, 2015
Merged
Feature/2886 general site settings#2979nbradbury merged 69 commits intofeature/site-settings-reviewfrom
nbradbury merged 69 commits intofeature/site-settings-reviewfrom
Conversation
Added attribute to set number of values on SeekBarPreference. Moved Summary updates to the fragment.
Adding class to handle limiting the summary size for certain preferences. Converting language codes for list preference values.
Contributor
|
I'm still seeing a couple of crashes:
|
Contributor
There was a problem hiding this comment.
It would be more bandwidth-friendly to only call applyChanges() when the user has actually made changes.
Contributor
Author
There was a problem hiding this comment.
applyChanges()makes sure there are changes by checking the params generated by 'generatePostParams()' before making a POST request.
Contributor
|
Just noticed that changes to the language preference aren't being retained. |
Contributor
Contributor
|
…-site-settings Conflicts: WordPress/src/main/res/values/strings.xml
Contributor
|
This is shaping up nicely and looks great, but there are a few minor issues still:
|
Contributor
Contributor
|
Looks good |
nbradbury
added a commit
that referenced
this pull request
Aug 26, 2015
…ite-settings Feature/2886 general site settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Moved from #2971
cc @nbradbury